You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/11/18 04:23:00 UTC
[jira] [Commented] (SOLR-11444) Improve Aliases.java and comma
delimited collection list handling
[ https://issues.apache.org/jira/browse/SOLR-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257914#comment-16257914 ]
ASF subversion and git services commented on SOLR-11444:
--------------------------------------------------------
Commit 6f99196e816761706e616325b3b2399867c571cc in lucene-solr's branch refs/heads/master from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f99196 ]
SOLR-11444: CloudSolrClient could have thrown an NPE if the collection doesn't exist.
Refactor: Tidy the exception throwing
> Improve Aliases.java and comma delimited collection list handling
> -----------------------------------------------------------------
>
> Key: SOLR-11444
> URL: https://issues.apache.org/jira/browse/SOLR-11444
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 7.2
>
> Attachments: SOLR-11444.patch, SOLR-11444.patch, SOLR_11444_Aliases.patch, SOLR_11444_Aliases.patch
>
>
> While starting to look at SOLR-11299 I noticed some brittleness in assumptions about Strings that refer to a collection. Sometimes they are in fact references to comma separated lists, which appears was added with the introduction of collection aliases (an alias can refer to a comma delimited list). So Java's type system kind of goes out the window when we do this. In one case this leads to a bug -- CloudSolrClient will throw an NPE if you try to write to such an alias. Sending an update via HTTP will allow it and send it to the first in the list.
> So this issue is about refactoring and some little improvements pertaining to Aliases.java plus certain key spots that deal with collection references. I don't think I want to go as far as changing the public SolrJ API except to adding documentation on what's possible.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org