You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Maxim Solodovnik <so...@gmail.com> on 2013/05/23 16:06:08 UTC
Re: svn commit: r1485714 - in /openmeetings/branches/2.1:
WebContent/openmeetings/ WebContent/src/ WebContent/src/base/
WebContent/swf10/ WebContent/swf10/base/ src/
Hello Artyom,
After your fix every client will report to account UA-13024987-1 at google
analytics, seems to be not very good feature.
Please remove it by default and make configurable by the end user
Thanks
On Thu, May 23, 2013 at 8:58 PM, <a_...@apache.org> wrote:
> Author: a_horuzhenko
> Date: Thu May 23 13:58:02 2013
> New Revision: 1485714
>
> URL: http://svn.apache.org/r1485714
> Log:
> 1. Basic send client errors reports functionality (not sure it works
> proper, should be tested).
> 2. Missing sip video window visibility has been fixed.
>
> Modified:
>
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> openmeetings/branches/2.1/WebContent/src/main.lzx
> openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> openmeetings/branches/2.1/src/usual_template.vm
>
> Modified:
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> ---
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> (original)
> +++
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> Thu May 23 13:58:02 2013
> @@ -23,6 +23,20 @@
> *
> */
>
> +var _gaq;
> +
> +function sendErrorReport(message) {
> + // Google Analytics
> + try {
> + _gaq = _gaq || [];
> + _gaq.push(['_setAccount', 'UA-13024987-1']);
> + _gaq.push(['_trackPageview']);
> + _gaq.push(['_trackEvent', 'Openmeetings client error',
> message, '', 0, true]);
> + } catch (exception) {
> + alert(exception);
> + }
> +}
> +
> function getBrowserInfo() {
> //alert(navigator.userAgent);
>
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
>
> Modified:
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> (original)
> +++ openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> Thu May 23 13:58:02 2013
> @@ -35,6 +35,9 @@
> var browserInfoReturnObject = null;
> var browserLangReturnObject = null;
>
> + function sendErrorReport(message) {
> + lz.Browser.callJS('sendErrorReport', null, message);
> + }
>
> function redirectToUrl(url, returnObject) {
>
>
> Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> +++ openmeetings/branches/2.1/WebContent/src/main.lzx Thu May 23 13:58:02
> 2013
> @@ -52,13 +52,16 @@
> <handler name="oninit">
> flash.external.ExternalInterface.call("loadingComplete");
> doDebugInit();
> - var cmenu = new LzContextMenu();
> - canvas.setDefaultContextMenu(cmenu);
> - cmenu.hideBuiltInItems();
> - if($debug) Debug.write("main.lzx/oninit:",this);
> - canvas.lc = new LocalConnection();
> + var cmenu = new LzContextMenu();
> + canvas.setDefaultContextMenu(cmenu);
> + cmenu.hideBuiltInItems();
> + if($debug) Debug.write("main.lzx/oninit:",this);
> + canvas.lc = new LocalConnection();
> </handler>
>
> +<handler name="onerror" args="errmsg">
> + sendErrorReport(errmsg);
> +</handler>
>
> <!-- View for Contents. All Windows will be loaded on this view. -->
> <view name="main_content" y="${ canvas.naviHeightDelta }"
> width="${canvas.width}"
>
> Modified: openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> (original)
> +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx Thu
> May 23 13:58:02 2013
> @@ -23,8 +23,15 @@
>
> <library>
>
> + <method name="onError" args="errorEvent">
> + lz.Browser.callJS('sendErrorReport', null,
> errorEvent.toString());
> + </method>
> +
> <method name="myinit">
> <![CDATA[
> + // Add listener to all uncaught errors
> +
> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
> onError);
> +
> canvas.mediaerrortimeout = 30000;
> canvas.medialoadtimeout = 30000;
>
>
> Modified:
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> ---
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> (original)
> +++
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> Thu May 23 13:58:02 2013
> @@ -139,7 +139,7 @@
> vidContainer.setVideouserProfilePic(object);
> if ($debug) Debug.warn("start play");
>
> vidContainer._chatvideoinner._videostream.playStream(broadcastId,-1);
> - vidContainer.setAttribute("visibility","visible");
> + vidContainer.setAttribute("visibility","hidden");
> } else if (avsettings=="v" || avsettings=="av") {
> //this means avsettings is either: "v" or "av"
>
> vidContainer.setDefaultVideoSize(object.VWidth,object.VHeight);
>
> Modified: openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> --- openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx (original)
> +++ openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx Thu May 23
> 13:58:02 2013
> @@ -25,6 +25,7 @@
> <passthrough>
> import flash.net.*;
> import flash.display.*;
> + import flash.events.*;
> </passthrough>
> </when>
> </switch>
>
> Modified: openmeetings/branches/2.1/src/usual_template.vm
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1485714&r1=1485713&r2=1485714&view=diff
>
> ==============================================================================
> --- openmeetings/branches/2.1/src/usual_template.vm (original)
> +++ openmeetings/branches/2.1/src/usual_template.vm Thu May 23 13:58:02
> 2013
> @@ -54,6 +54,8 @@ limitations under the License.
> <script type="text/javascript"
> src="embed-compressed.js"></script>
> <script type="text/javascript"
> + src="http://www.google-analytics.com/ga.js"></script>
> +<script type="text/javascript"
> src="openmeetings_functions.js"></script>
> <script type="text/javascript">
>
>
>
>
--
WBR
Maxim aka solomax
Re: svn commit: r1485714 - in /openmeetings/branches/2.1:
WebContent/openmeetings/ WebContent/src/ WebContent/src/base/
WebContent/swf10/ WebContent/swf10/base/ src/
Posted by Artyom Horuzhenko <ak...@gmail.com>.
Switched of by default error reports will be usless. I agree that it would
be better to revert this revision, but please don't revert sip video window
fix.
28.05.2013 7:24 пользователь "Maxim Solodovnik" <so...@gmail.com>
написал:
> This is the friendly reminder to make Google analytics support OFF by
> default and configurable.
> Artyom, please implement this or I will revert your patch.
>
> Thanks!
>
>
>
> On Fri, May 24, 2013 at 2:27 PM, seba.wagner@gmail.com <
> seba.wagner@gmail.com> wrote:
>
>> Hi there,
>>
>> I second Maxims view of not having any kind of tracking code installed by
>> default.
>>
>> Cheers,
>> Sebastian
>> Am 24.05.2013 19:15 schrieb "Alexei Fedotov" <al...@gmail.com>:
>>
>> > Hello Maxim,
>> >
>> > This is my account, right now I may provide any committer with access to
>> > the collected bugs. The configuration will be added ASAP, right now
>> anyone
>> > can just patch this code.
>> >
>> > We may also create a dedicated account with PMC/committer access. This
>> will
>> > give us immediate feedback on user problems.
>> >
>> > BTW, Artyom, is openmeetings revision a part of the report?
>> >
>> > --
>> > With best regards / с наилучшими пожеланиями,
>> > Alexei Fedotov / Алексей Федотов,
>> > http://dataved.ru/
>> > +7 916 562 8095
>> >
>> >
>> > On Thu, May 23, 2013 at 6:06 PM, Maxim Solodovnik <solomax666@gmail.com
>> > >wrote:
>> >
>> > > Hello Artyom,
>> > >
>> > > After your fix every client will report to account UA-13024987-1 at
>> > google
>> > > analytics, seems to be not very good feature.
>> > > Please remove it by default and make configurable by the end user
>> > >
>> > > Thanks
>> > >
>> > >
>> > > On Thu, May 23, 2013 at 8:58 PM, <a_...@apache.org> wrote:
>> > >
>> > > > Author: a_horuzhenko
>> > > > Date: Thu May 23 13:58:02 2013
>> > > > New Revision: 1485714
>> > > >
>> > > > URL: http://svn.apache.org/r1485714
>> > > > Log:
>> > > > 1. Basic send client errors reports functionality (not sure it works
>> > > > proper, should be tested).
>> > > > 2. Missing sip video window visibility has been fixed.
>> > > >
>> > > > Modified:
>> > > >
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> > > >
>> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> > > > openmeetings/branches/2.1/WebContent/src/main.lzx
>> > > > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> > > >
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
>> > > > openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
>> > > > openmeetings/branches/2.1/src/usual_template.vm
>> > > >
>> > > > Modified:
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > ---
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> > > > (original)
>> > > > +++
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
>> > > > Thu May 23 13:58:02 2013
>> > > > @@ -23,6 +23,20 @@
>> > > > *
>> > > > */
>> > > >
>> > > > +var _gaq;
>> > > > +
>> > > > +function sendErrorReport(message) {
>> > > > + // Google Analytics
>> > > > + try {
>> > > > + _gaq = _gaq || [];
>> > > > + _gaq.push(['_setAccount', 'UA-13024987-1']);
>> > > > + _gaq.push(['_trackPageview']);
>> > > > + _gaq.push(['_trackEvent', 'Openmeetings client
>> error',
>> > > > message, '', 0, true]);
>> > > > + } catch (exception) {
>> > > > + alert(exception);
>> > > > + }
>> > > > +}
>> > > > +
>> > > > function getBrowserInfo() {
>> > > > //alert(navigator.userAgent);
>> > > >
>> > > >
>> > >
>> >
>> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
>> > > >
>> > > > Modified:
>> > > > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > ---
>> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> > > > (original)
>> > > > +++
>> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
>> > > > Thu May 23 13:58:02 2013
>> > > > @@ -35,6 +35,9 @@
>> > > > var browserInfoReturnObject = null;
>> > > > var browserLangReturnObject = null;
>> > > >
>> > > > + function sendErrorReport(message) {
>> > > > + lz.Browser.callJS('sendErrorReport', null, message);
>> > > > + }
>> > > >
>> > > > function redirectToUrl(url, returnObject) {
>> > > >
>> > > >
>> > > > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
>> > > > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Thu May 23
>> > 13:58:02
>> > > > 2013
>> > > > @@ -52,13 +52,16 @@
>> > > > <handler name="oninit">
>> > > > flash.external.ExternalInterface.call("loadingComplete");
>> > > > doDebugInit();
>> > > > - var cmenu = new LzContextMenu();
>> > > > - canvas.setDefaultContextMenu(cmenu);
>> > > > - cmenu.hideBuiltInItems();
>> > > > - if($debug) Debug.write("main.lzx/oninit:",this);
>> > > > - canvas.lc = new LocalConnection();
>> > > > + var cmenu = new LzContextMenu();
>> > > > + canvas.setDefaultContextMenu(cmenu);
>> > > > + cmenu.hideBuiltInItems();
>> > > > + if($debug) Debug.write("main.lzx/oninit:",this);
>> > > > + canvas.lc = new LocalConnection();
>> > > > </handler>
>> > > >
>> > > > +<handler name="onerror" args="errmsg">
>> > > > + sendErrorReport(errmsg);
>> > > > +</handler>
>> > > >
>> > > > <!-- View for Contents. All Windows will be loaded on this view.
>> -->
>> > > > <view name="main_content" y="${ canvas.naviHeightDelta }"
>> > > > width="${canvas.width}"
>> > > >
>> > > > Modified:
>> > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> > > > (original)
>> > > > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
>> Thu
>> > > > May 23 13:58:02 2013
>> > > > @@ -23,8 +23,15 @@
>> > > >
>> > > > <library>
>> > > >
>> > > > + <method name="onError" args="errorEvent">
>> > > > + lz.Browser.callJS('sendErrorReport', null,
>> > > > errorEvent.toString());
>> > > > + </method>
>> > > > +
>> > > > <method name="myinit">
>> > > > <![CDATA[
>> > > > + // Add listener to all uncaught errors
>> > > > +
>> > > >
>> > >
>> >
>> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
>> > > > onError);
>> > > > +
>> > > > canvas.mediaerrortimeout = 30000;
>> > > > canvas.medialoadtimeout = 30000;
>> > > >
>> > > >
>> > > > Modified:
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > ---
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
>> > > > (original)
>> > > > +++
>> > > >
>> > >
>> >
>> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
>> > > > Thu May 23 13:58:02 2013
>> > > > @@ -139,7 +139,7 @@
>> > > > vidContainer.setVideouserProfilePic(object);
>> > > > if ($debug) Debug.warn("start play");
>> > > >
>> > > >
>> vidContainer._chatvideoinner._videostream.playStream(broadcastId,-1);
>> > > > -
>> vidContainer.setAttribute("visibility","visible");
>> > > > +
>> vidContainer.setAttribute("visibility","hidden");
>> > > > } else if (avsettings=="v" || avsettings=="av") {
>> > > > //this means avsettings is either: "v" or "av"
>> > > >
>> > > > vidContainer.setDefaultVideoSize(object.VWidth,object.VHeight);
>> > > >
>> > > > Modified: openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > --- openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
>> (original)
>> > > > +++ openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx Thu May
>> 23
>> > > > 13:58:02 2013
>> > > > @@ -25,6 +25,7 @@
>> > > > <passthrough>
>> > > > import flash.net.*;
>> > > > import flash.display.*;
>> > > > + import flash.events.*;
>> > > > </passthrough>
>> > > > </when>
>> > > > </switch>
>> > > >
>> > > > Modified: openmeetings/branches/2.1/src/usual_template.vm
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1485714&r1=1485713&r2=1485714&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > --- openmeetings/branches/2.1/src/usual_template.vm (original)
>> > > > +++ openmeetings/branches/2.1/src/usual_template.vm Thu May 23
>> 13:58:02
>> > > > 2013
>> > > > @@ -54,6 +54,8 @@ limitations under the License.
>> > > > <script type="text/javascript"
>> > > > src="embed-compressed.js"></script>
>> > > > <script type="text/javascript"
>> > > > + src="http://www.google-analytics.com/ga.js"></script>
>> > > > +<script type="text/javascript"
>> > > > src="openmeetings_functions.js"></script>
>> > > > <script type="text/javascript">
>> > > >
>> > > >
>> > > >
>> > > >
>> > >
>> > >
>> > > --
>> > > WBR
>> > > Maxim aka solomax
>> > >
>> >
>>
>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: svn commit: r1485714 - in /openmeetings/branches/2.1:
WebContent/openmeetings/ WebContent/src/ WebContent/src/base/
WebContent/swf10/ WebContent/swf10/base/ src/
Posted by Maxim Solodovnik <so...@gmail.com>.
This is the friendly reminder to make Google analytics support OFF by
default and configurable.
Artyom, please implement this or I will revert your patch.
Thanks!
On Fri, May 24, 2013 at 2:27 PM, seba.wagner@gmail.com <
seba.wagner@gmail.com> wrote:
> Hi there,
>
> I second Maxims view of not having any kind of tracking code installed by
> default.
>
> Cheers,
> Sebastian
> Am 24.05.2013 19:15 schrieb "Alexei Fedotov" <al...@gmail.com>:
>
> > Hello Maxim,
> >
> > This is my account, right now I may provide any committer with access to
> > the collected bugs. The configuration will be added ASAP, right now
> anyone
> > can just patch this code.
> >
> > We may also create a dedicated account with PMC/committer access. This
> will
> > give us immediate feedback on user problems.
> >
> > BTW, Artyom, is openmeetings revision a part of the report?
> >
> > --
> > With best regards / с наилучшими пожеланиями,
> > Alexei Fedotov / Алексей Федотов,
> > http://dataved.ru/
> > +7 916 562 8095
> >
> >
> > On Thu, May 23, 2013 at 6:06 PM, Maxim Solodovnik <solomax666@gmail.com
> > >wrote:
> >
> > > Hello Artyom,
> > >
> > > After your fix every client will report to account UA-13024987-1 at
> > google
> > > analytics, seems to be not very good feature.
> > > Please remove it by default and make configurable by the end user
> > >
> > > Thanks
> > >
> > >
> > > On Thu, May 23, 2013 at 8:58 PM, <a_...@apache.org> wrote:
> > >
> > > > Author: a_horuzhenko
> > > > Date: Thu May 23 13:58:02 2013
> > > > New Revision: 1485714
> > > >
> > > > URL: http://svn.apache.org/r1485714
> > > > Log:
> > > > 1. Basic send client errors reports functionality (not sure it works
> > > > proper, should be tested).
> > > > 2. Missing sip video window visibility has been fixed.
> > > >
> > > > Modified:
> > > >
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > >
> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > > openmeetings/branches/2.1/WebContent/src/main.lzx
> > > > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > > >
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > > openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> > > > openmeetings/branches/2.1/src/usual_template.vm
> > > >
> > > > Modified:
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > ---
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > > (original)
> > > > +++
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > > Thu May 23 13:58:02 2013
> > > > @@ -23,6 +23,20 @@
> > > > *
> > > > */
> > > >
> > > > +var _gaq;
> > > > +
> > > > +function sendErrorReport(message) {
> > > > + // Google Analytics
> > > > + try {
> > > > + _gaq = _gaq || [];
> > > > + _gaq.push(['_setAccount', 'UA-13024987-1']);
> > > > + _gaq.push(['_trackPageview']);
> > > > + _gaq.push(['_trackEvent', 'Openmeetings client
> error',
> > > > message, '', 0, true]);
> > > > + } catch (exception) {
> > > > + alert(exception);
> > > > + }
> > > > +}
> > > > +
> > > > function getBrowserInfo() {
> > > > //alert(navigator.userAgent);
> > > >
> > > >
> > >
> >
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
> > > >
> > > > Modified:
> > > > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > ---
> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > > (original)
> > > > +++
> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > > Thu May 23 13:58:02 2013
> > > > @@ -35,6 +35,9 @@
> > > > var browserInfoReturnObject = null;
> > > > var browserLangReturnObject = null;
> > > >
> > > > + function sendErrorReport(message) {
> > > > + lz.Browser.callJS('sendErrorReport', null, message);
> > > > + }
> > > >
> > > > function redirectToUrl(url, returnObject) {
> > > >
> > > >
> > > > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> > > > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Thu May 23
> > 13:58:02
> > > > 2013
> > > > @@ -52,13 +52,16 @@
> > > > <handler name="oninit">
> > > > flash.external.ExternalInterface.call("loadingComplete");
> > > > doDebugInit();
> > > > - var cmenu = new LzContextMenu();
> > > > - canvas.setDefaultContextMenu(cmenu);
> > > > - cmenu.hideBuiltInItems();
> > > > - if($debug) Debug.write("main.lzx/oninit:",this);
> > > > - canvas.lc = new LocalConnection();
> > > > + var cmenu = new LzContextMenu();
> > > > + canvas.setDefaultContextMenu(cmenu);
> > > > + cmenu.hideBuiltInItems();
> > > > + if($debug) Debug.write("main.lzx/oninit:",this);
> > > > + canvas.lc = new LocalConnection();
> > > > </handler>
> > > >
> > > > +<handler name="onerror" args="errmsg">
> > > > + sendErrorReport(errmsg);
> > > > +</handler>
> > > >
> > > > <!-- View for Contents. All Windows will be loaded on this view. -->
> > > > <view name="main_content" y="${ canvas.naviHeightDelta }"
> > > > width="${canvas.width}"
> > > >
> > > > Modified:
> > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > > > (original)
> > > > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> Thu
> > > > May 23 13:58:02 2013
> > > > @@ -23,8 +23,15 @@
> > > >
> > > > <library>
> > > >
> > > > + <method name="onError" args="errorEvent">
> > > > + lz.Browser.callJS('sendErrorReport', null,
> > > > errorEvent.toString());
> > > > + </method>
> > > > +
> > > > <method name="myinit">
> > > > <![CDATA[
> > > > + // Add listener to all uncaught errors
> > > > +
> > > >
> > >
> >
> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
> > > > onError);
> > > > +
> > > > canvas.mediaerrortimeout = 30000;
> > > > canvas.medialoadtimeout = 30000;
> > > >
> > > >
> > > > Modified:
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > ---
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > > (original)
> > > > +++
> > > >
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > > Thu May 23 13:58:02 2013
> > > > @@ -139,7 +139,7 @@
> > > > vidContainer.setVideouserProfilePic(object);
> > > > if ($debug) Debug.warn("start play");
> > > >
> > > >
> vidContainer._chatvideoinner._videostream.playStream(broadcastId,-1);
> > > > -
> vidContainer.setAttribute("visibility","visible");
> > > > +
> vidContainer.setAttribute("visibility","hidden");
> > > > } else if (avsettings=="v" || avsettings=="av") {
> > > > //this means avsettings is either: "v" or "av"
> > > >
> > > > vidContainer.setDefaultVideoSize(object.VWidth,object.VHeight);
> > > >
> > > > Modified: openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > --- openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> (original)
> > > > +++ openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx Thu May
> 23
> > > > 13:58:02 2013
> > > > @@ -25,6 +25,7 @@
> > > > <passthrough>
> > > > import flash.net.*;
> > > > import flash.display.*;
> > > > + import flash.events.*;
> > > > </passthrough>
> > > > </when>
> > > > </switch>
> > > >
> > > > Modified: openmeetings/branches/2.1/src/usual_template.vm
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1485714&r1=1485713&r2=1485714&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > --- openmeetings/branches/2.1/src/usual_template.vm (original)
> > > > +++ openmeetings/branches/2.1/src/usual_template.vm Thu May 23
> 13:58:02
> > > > 2013
> > > > @@ -54,6 +54,8 @@ limitations under the License.
> > > > <script type="text/javascript"
> > > > src="embed-compressed.js"></script>
> > > > <script type="text/javascript"
> > > > + src="http://www.google-analytics.com/ga.js"></script>
> > > > +<script type="text/javascript"
> > > > src="openmeetings_functions.js"></script>
> > > > <script type="text/javascript">
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
>
--
WBR
Maxim aka solomax
Re: svn commit: r1485714 - in /openmeetings/branches/2.1:
WebContent/openmeetings/ WebContent/src/ WebContent/src/base/
WebContent/swf10/ WebContent/swf10/base/ src/
Posted by "seba.wagner@gmail.com" <se...@gmail.com>.
Hi there,
I second Maxims view of not having any kind of tracking code installed by
default.
Cheers,
Sebastian
Am 24.05.2013 19:15 schrieb "Alexei Fedotov" <al...@gmail.com>:
> Hello Maxim,
>
> This is my account, right now I may provide any committer with access to
> the collected bugs. The configuration will be added ASAP, right now anyone
> can just patch this code.
>
> We may also create a dedicated account with PMC/committer access. This will
> give us immediate feedback on user problems.
>
> BTW, Artyom, is openmeetings revision a part of the report?
>
> --
> With best regards / с наилучшими пожеланиями,
> Alexei Fedotov / Алексей Федотов,
> http://dataved.ru/
> +7 916 562 8095
>
>
> On Thu, May 23, 2013 at 6:06 PM, Maxim Solodovnik <solomax666@gmail.com
> >wrote:
>
> > Hello Artyom,
> >
> > After your fix every client will report to account UA-13024987-1 at
> google
> > analytics, seems to be not very good feature.
> > Please remove it by default and make configurable by the end user
> >
> > Thanks
> >
> >
> > On Thu, May 23, 2013 at 8:58 PM, <a_...@apache.org> wrote:
> >
> > > Author: a_horuzhenko
> > > Date: Thu May 23 13:58:02 2013
> > > New Revision: 1485714
> > >
> > > URL: http://svn.apache.org/r1485714
> > > Log:
> > > 1. Basic send client errors reports functionality (not sure it works
> > > proper, should be tested).
> > > 2. Missing sip video window visibility has been fixed.
> > >
> > > Modified:
> > >
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > >
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > openmeetings/branches/2.1/WebContent/src/main.lzx
> > > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > >
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> > > openmeetings/branches/2.1/src/usual_template.vm
> > >
> > > Modified:
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > ---
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > (original)
> > > +++
> > >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > > Thu May 23 13:58:02 2013
> > > @@ -23,6 +23,20 @@
> > > *
> > > */
> > >
> > > +var _gaq;
> > > +
> > > +function sendErrorReport(message) {
> > > + // Google Analytics
> > > + try {
> > > + _gaq = _gaq || [];
> > > + _gaq.push(['_setAccount', 'UA-13024987-1']);
> > > + _gaq.push(['_trackPageview']);
> > > + _gaq.push(['_trackEvent', 'Openmeetings client error',
> > > message, '', 0, true]);
> > > + } catch (exception) {
> > > + alert(exception);
> > > + }
> > > +}
> > > +
> > > function getBrowserInfo() {
> > > //alert(navigator.userAgent);
> > >
> > >
> >
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
> > >
> > > Modified:
> > > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > ---
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > (original)
> > > +++
> openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > > Thu May 23 13:58:02 2013
> > > @@ -35,6 +35,9 @@
> > > var browserInfoReturnObject = null;
> > > var browserLangReturnObject = null;
> > >
> > > + function sendErrorReport(message) {
> > > + lz.Browser.callJS('sendErrorReport', null, message);
> > > + }
> > >
> > > function redirectToUrl(url, returnObject) {
> > >
> > >
> > > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> > > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Thu May 23
> 13:58:02
> > > 2013
> > > @@ -52,13 +52,16 @@
> > > <handler name="oninit">
> > > flash.external.ExternalInterface.call("loadingComplete");
> > > doDebugInit();
> > > - var cmenu = new LzContextMenu();
> > > - canvas.setDefaultContextMenu(cmenu);
> > > - cmenu.hideBuiltInItems();
> > > - if($debug) Debug.write("main.lzx/oninit:",this);
> > > - canvas.lc = new LocalConnection();
> > > + var cmenu = new LzContextMenu();
> > > + canvas.setDefaultContextMenu(cmenu);
> > > + cmenu.hideBuiltInItems();
> > > + if($debug) Debug.write("main.lzx/oninit:",this);
> > > + canvas.lc = new LocalConnection();
> > > </handler>
> > >
> > > +<handler name="onerror" args="errmsg">
> > > + sendErrorReport(errmsg);
> > > +</handler>
> > >
> > > <!-- View for Contents. All Windows will be loaded on this view. -->
> > > <view name="main_content" y="${ canvas.naviHeightDelta }"
> > > width="${canvas.width}"
> > >
> > > Modified:
> openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > > (original)
> > > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx Thu
> > > May 23 13:58:02 2013
> > > @@ -23,8 +23,15 @@
> > >
> > > <library>
> > >
> > > + <method name="onError" args="errorEvent">
> > > + lz.Browser.callJS('sendErrorReport', null,
> > > errorEvent.toString());
> > > + </method>
> > > +
> > > <method name="myinit">
> > > <![CDATA[
> > > + // Add listener to all uncaught errors
> > > +
> > >
> >
> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
> > > onError);
> > > +
> > > canvas.mediaerrortimeout = 30000;
> > > canvas.medialoadtimeout = 30000;
> > >
> > >
> > > Modified:
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > ---
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > (original)
> > > +++
> > >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > > Thu May 23 13:58:02 2013
> > > @@ -139,7 +139,7 @@
> > > vidContainer.setVideouserProfilePic(object);
> > > if ($debug) Debug.warn("start play");
> > >
> > > vidContainer._chatvideoinner._videostream.playStream(broadcastId,-1);
> > > - vidContainer.setAttribute("visibility","visible");
> > > + vidContainer.setAttribute("visibility","hidden");
> > > } else if (avsettings=="v" || avsettings=="av") {
> > > //this means avsettings is either: "v" or "av"
> > >
> > > vidContainer.setDefaultVideoSize(object.VWidth,object.VHeight);
> > >
> > > Modified: openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > --- openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx (original)
> > > +++ openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx Thu May 23
> > > 13:58:02 2013
> > > @@ -25,6 +25,7 @@
> > > <passthrough>
> > > import flash.net.*;
> > > import flash.display.*;
> > > + import flash.events.*;
> > > </passthrough>
> > > </when>
> > > </switch>
> > >
> > > Modified: openmeetings/branches/2.1/src/usual_template.vm
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1485714&r1=1485713&r2=1485714&view=diff
> > >
> > >
> >
> ==============================================================================
> > > --- openmeetings/branches/2.1/src/usual_template.vm (original)
> > > +++ openmeetings/branches/2.1/src/usual_template.vm Thu May 23 13:58:02
> > > 2013
> > > @@ -54,6 +54,8 @@ limitations under the License.
> > > <script type="text/javascript"
> > > src="embed-compressed.js"></script>
> > > <script type="text/javascript"
> > > + src="http://www.google-analytics.com/ga.js"></script>
> > > +<script type="text/javascript"
> > > src="openmeetings_functions.js"></script>
> > > <script type="text/javascript">
> > >
> > >
> > >
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
Re: svn commit: r1485714 - in /openmeetings/branches/2.1:
WebContent/openmeetings/ WebContent/src/ WebContent/src/base/
WebContent/swf10/ WebContent/swf10/base/ src/
Posted by Alexei Fedotov <al...@gmail.com>.
Hello Maxim,
This is my account, right now I may provide any committer with access to
the collected bugs. The configuration will be added ASAP, right now anyone
can just patch this code.
We may also create a dedicated account with PMC/committer access. This will
give us immediate feedback on user problems.
BTW, Artyom, is openmeetings revision a part of the report?
--
With best regards / с наилучшими пожеланиями,
Alexei Fedotov / Алексей Федотов,
http://dataved.ru/
+7 916 562 8095
On Thu, May 23, 2013 at 6:06 PM, Maxim Solodovnik <so...@gmail.com>wrote:
> Hello Artyom,
>
> After your fix every client will report to account UA-13024987-1 at google
> analytics, seems to be not very good feature.
> Please remove it by default and make configurable by the end user
>
> Thanks
>
>
> On Thu, May 23, 2013 at 8:58 PM, <a_...@apache.org> wrote:
>
> > Author: a_horuzhenko
> > Date: Thu May 23 13:58:02 2013
> > New Revision: 1485714
> >
> > URL: http://svn.apache.org/r1485714
> > Log:
> > 1. Basic send client errors reports functionality (not sure it works
> > proper, should be tested).
> > 2. Missing sip video window visibility has been fixed.
> >
> > Modified:
> >
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > openmeetings/branches/2.1/WebContent/src/main.lzx
> > openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> >
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> > openmeetings/branches/2.1/src/usual_template.vm
> >
> > Modified:
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > (original)
> > +++
> >
> openmeetings/branches/2.1/WebContent/openmeetings/openmeetings_functions.js
> > Thu May 23 13:58:02 2013
> > @@ -23,6 +23,20 @@
> > *
> > */
> >
> > +var _gaq;
> > +
> > +function sendErrorReport(message) {
> > + // Google Analytics
> > + try {
> > + _gaq = _gaq || [];
> > + _gaq.push(['_setAccount', 'UA-13024987-1']);
> > + _gaq.push(['_trackPageview']);
> > + _gaq.push(['_trackEvent', 'Openmeetings client error',
> > message, '', 0, true]);
> > + } catch (exception) {
> > + alert(exception);
> > + }
> > +}
> > +
> > function getBrowserInfo() {
> > //alert(navigator.userAgent);
> >
> >
> document.getElementById("lzapp").getBrowserInfoCallback(navigator.userAgent);
> >
> > Modified:
> > openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > (original)
> > +++ openmeetings/branches/2.1/WebContent/src/base/externalJavaScript.lzx
> > Thu May 23 13:58:02 2013
> > @@ -35,6 +35,9 @@
> > var browserInfoReturnObject = null;
> > var browserLangReturnObject = null;
> >
> > + function sendErrorReport(message) {
> > + lz.Browser.callJS('sendErrorReport', null, message);
> > + }
> >
> > function redirectToUrl(url, returnObject) {
> >
> >
> > Modified: openmeetings/branches/2.1/WebContent/src/main.lzx
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/src/main.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/src/main.lzx (original)
> > +++ openmeetings/branches/2.1/WebContent/src/main.lzx Thu May 23 13:58:02
> > 2013
> > @@ -52,13 +52,16 @@
> > <handler name="oninit">
> > flash.external.ExternalInterface.call("loadingComplete");
> > doDebugInit();
> > - var cmenu = new LzContextMenu();
> > - canvas.setDefaultContextMenu(cmenu);
> > - cmenu.hideBuiltInItems();
> > - if($debug) Debug.write("main.lzx/oninit:",this);
> > - canvas.lc = new LocalConnection();
> > + var cmenu = new LzContextMenu();
> > + canvas.setDefaultContextMenu(cmenu);
> > + cmenu.hideBuiltInItems();
> > + if($debug) Debug.write("main.lzx/oninit:",this);
> > + canvas.lc = new LocalConnection();
> > </handler>
> >
> > +<handler name="onerror" args="errmsg">
> > + sendErrorReport(errmsg);
> > +</handler>
> >
> > <!-- View for Contents. All Windows will be loaded on this view. -->
> > <view name="main_content" y="${ canvas.naviHeightDelta }"
> > width="${canvas.width}"
> >
> > Modified: openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx
> > (original)
> > +++ openmeetings/branches/2.1/WebContent/swf10/base/mainMethods.lzx Thu
> > May 23 13:58:02 2013
> > @@ -23,8 +23,15 @@
> >
> > <library>
> >
> > + <method name="onError" args="errorEvent">
> > + lz.Browser.callJS('sendErrorReport', null,
> > errorEvent.toString());
> > + </method>
> > +
> > <method name="myinit">
> > <![CDATA[
> > + // Add listener to all uncaught errors
> > +
> >
> this.getDisplayObject().loaderInfo.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR,
> > onError);
> > +
> > canvas.mediaerrortimeout = 30000;
> > canvas.medialoadtimeout = 30000;
> >
> >
> > Modified:
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > (original)
> > +++
> >
> openmeetings/branches/2.1/WebContent/swf10/commonVideoViewContentSWF10.lzx
> > Thu May 23 13:58:02 2013
> > @@ -139,7 +139,7 @@
> > vidContainer.setVideouserProfilePic(object);
> > if ($debug) Debug.warn("start play");
> >
> > vidContainer._chatvideoinner._videostream.playStream(broadcastId,-1);
> > - vidContainer.setAttribute("visibility","visible");
> > + vidContainer.setAttribute("visibility","hidden");
> > } else if (avsettings=="v" || avsettings=="av") {
> > //this means avsettings is either: "v" or "av"
> >
> > vidContainer.setDefaultVideoSize(object.VWidth,object.VHeight);
> >
> > Modified: openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx (original)
> > +++ openmeetings/branches/2.1/WebContent/swf10/main.as3.lzx Thu May 23
> > 13:58:02 2013
> > @@ -25,6 +25,7 @@
> > <passthrough>
> > import flash.net.*;
> > import flash.display.*;
> > + import flash.events.*;
> > </passthrough>
> > </when>
> > </switch>
> >
> > Modified: openmeetings/branches/2.1/src/usual_template.vm
> > URL:
> >
> http://svn.apache.org/viewvc/openmeetings/branches/2.1/src/usual_template.vm?rev=1485714&r1=1485713&r2=1485714&view=diff
> >
> >
> ==============================================================================
> > --- openmeetings/branches/2.1/src/usual_template.vm (original)
> > +++ openmeetings/branches/2.1/src/usual_template.vm Thu May 23 13:58:02
> > 2013
> > @@ -54,6 +54,8 @@ limitations under the License.
> > <script type="text/javascript"
> > src="embed-compressed.js"></script>
> > <script type="text/javascript"
> > + src="http://www.google-analytics.com/ga.js"></script>
> > +<script type="text/javascript"
> > src="openmeetings_functions.js"></script>
> > <script type="text/javascript">
> >
> >
> >
> >
>
>
> --
> WBR
> Maxim aka solomax
>