[GitHub] [incubator-iceberg] Parth-Brahmbhatt commented on a change in pull request #165: Adding the catalog interface to allow iceberg to handle top level catalog operations.

[GitBox <gi...@apache.org>]

Parth-Brahmbhatt commented on a change in pull request #165: Adding the catalog interface to allow iceberg to handle top level catalog operations.
URL: https://github.com/apache/incubator-iceberg/pull/165#discussion_r276841094
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
 ##########
 @@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.catalog;
+
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.Table;
+import org.apache.iceberg.exceptions.AlreadyExistsException;
+import org.apache.iceberg.exceptions.NoSuchTableException;
+
+import java.util.List;
+
+public interface Catalog {
+  /**
+   * creates the table or throws {@link AlreadyExistsException}.
+   * @param schema
+   * @param spec
+   * @param tableIdentifier
+   * @return Table instance that was created
+   */
+  Table createTable(Schema schema, PartitionSpec spec, TableIdentifier tableIdentifier);
+
+  /**
+   * check if tables exists or not.
+   * @param tableIdentifier
+   * @return true if table exists, false if it doesn't.
+   */
+  boolean tableExists(TableIdentifier tableIdentifier);
+
+  /**
+   * Drops the table if it exists, otherwise throws {@link NoSuchTableException}
+   * @param tableIdentifier
+   * @param shouldDeleteData should the data corresponding to this table be deleted
+   */
+  void dropTable(TableIdentifier tableIdentifier, boolean shouldDeleteData);
+
+  /**
+   * Renames a table. If @{code from} does not exists throws {@link NoSuchTableException}
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org