You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by YangTerry <po...@hotmail.com> on 2012/06/20 10:31:59 UTC
[RELEASE][3.4.1]: proposing "Bug 119803 - After upgrading to 3.4 RTF User Fields are not saving " as release blocker
This is a bug about user fields lost after save in RTF file.
This is a regression issue, it is work fine in OOo 3.3.
ej197us@gmail.com
2012-06-07 10:23:13 UTC
To duplicate:
Create a rtf document with a version < 3.4.
Menu Options
Insert
-Field
--Other
---User Fields
At this point the variable list is shown.
Insert a new variable and click the green check.
The variable shows up in the list and appears to be saving.
Insert the variable into the document to use it.
Close the doc and reopen.
When the document reopens the variable is not present and is de-referenced in the doc.
This appears to be a critical error. This function is used by many developers along with UNO to published merged documents.
Resolution: Downgrade OpenOffice to <3.4.
Thanks,
Terry Yang
Re: [RELEASE][3.4.1]Release Bloker: proposing "Bug 119803 - After
upgrading to 3.4 RTF User Fields are not saving"
Posted by Oliver-Rainer Wittmann <or...@googlemail.com>.
Hi,
On 26.06.2012 16:07, Lin Yuan wrote:
> In cws vmiklos01, the field export for rtf filter and ms word filter is
> integrated into AttributeOutputBase::TextField() in
> sw\source\filter\ww8\ww8atr.cxx . However, the processing for user field
> and db field is different for rtf and ms word filter. And In AOO3.4 the
> processing for the two fields is missed in rtf export filter. I have
> submitted a patch to 119803 that add
> the processing for the two field for rtf filter to
> RtfAttributeOutput::WriteExpand() in
> sw\source\filter\ww8\rtfattributeoutput.cxx
> Please help reivew it. Thanks
>
> [1] bug 119803
> https://issues.apache.org/ooo/show_bug.cgi?id=119803
> [2] patch to fix 119803
> https://issues.apache.org/ooo/attachment.cgi?id=78498&action=diff
>
Thx for the patch.
I am volunteering to review the patch.
Best regards, Oliver.
> Thanks,
> Lin Yuan
> 2012/6/21 Lin Yuan <yu...@gmail.com>
>
>> May related to CWS vmiklos01 which refactor the RTF filter. Seems some
>> field related processing in sw\source\filter\ww8\rtfattributeoutput.cxx is
>> not implemented yet. I will do more investigation to know how many codes
>> need to be added and if it can be contained in 3.4.1 scope.
>>
>>
>> 2012/6/21 Jürgen Schmidt <jo...@googlemail.com>
>>
>>> On 6/21/12 3:45 AM, YangTerry wrote:
>>>>
>>>> Re-send it, seems failed last time.
>>>>
>>>> This is a bug about user fields lost after save in RTF file.
>>>> This is a regression issue, it is work fine in OOo 3.3.
>>>>> ej197us@gmail.com
>>>>> 2012-06-07 10:23:13 UTC
>>>>> To duplicate:
>>>>> Create a rtf document with a version < 3.4.
>>>>> Menu Options
>>>>> Insert
>>>>> -Field
>>>>> --Other
>>>>> ---User Fields
>>>>>
>>>>> At this point the variable list is shown.
>>>>>
>>>>> Insert a new variable and click the green check.
>>>>>
>>>>> The variable shows up in the list and appears to be saving.
>>>>>
>>>>> Insert the variable into the document to use it.
>>>>>
>>>>> Close the doc and reopen.
>>>>>
>>>>> When the document reopens the variable is not present and is
>>> de-referenced in the doc.
>>>>>
>>>>> This appears to be a critical error. This function is used by many
>>> developers along with UNO to published merged documents.
>>>>>
>>>>> Resolution: Downgrade OpenOffice to <3.4.
>>>>>
>>>
>>> +1 if it's a regression than it's fine for me. Who will take care of
>>> this issue?
>>>
>>> Juergen
>>>
>>>
>>>
>>
>
Re: [RELEASE][3.4.1]Release Bloker: proposing "Bug 119803 - After
upgrading to 3.4 RTF User Fields are not saving"
Posted by Lin Yuan <yu...@gmail.com>.
In cws vmiklos01, the field export for rtf filter and ms word filter is
integrated into AttributeOutputBase::TextField() in
sw\source\filter\ww8\ww8atr.cxx . However, the processing for user field
and db field is different for rtf and ms word filter. And In AOO3.4 the
processing for the two fields is missed in rtf export filter. I have
submitted a patch to 119803 that add
the processing for the two field for rtf filter to
RtfAttributeOutput::WriteExpand() in
sw\source\filter\ww8\rtfattributeoutput.cxx
Please help reivew it. Thanks
[1] bug 119803
https://issues.apache.org/ooo/show_bug.cgi?id=119803
[2] patch to fix 119803
https://issues.apache.org/ooo/attachment.cgi?id=78498&action=diff
Thanks,
Lin Yuan
2012/6/21 Lin Yuan <yu...@gmail.com>
> May related to CWS vmiklos01 which refactor the RTF filter. Seems some
> field related processing in sw\source\filter\ww8\rtfattributeoutput.cxx is
> not implemented yet. I will do more investigation to know how many codes
> need to be added and if it can be contained in 3.4.1 scope.
>
>
> 2012/6/21 Jürgen Schmidt <jo...@googlemail.com>
>
>> On 6/21/12 3:45 AM, YangTerry wrote:
>> >
>> > Re-send it, seems failed last time.
>> >
>> > This is a bug about user fields lost after save in RTF file.
>> > This is a regression issue, it is work fine in OOo 3.3.
>> >> ej197us@gmail.com
>> >> 2012-06-07 10:23:13 UTC
>> >> To duplicate:
>> >> Create a rtf document with a version < 3.4.
>> >> Menu Options
>> >> Insert
>> >> -Field
>> >> --Other
>> >> ---User Fields
>> >>
>> >> At this point the variable list is shown.
>> >>
>> >> Insert a new variable and click the green check.
>> >>
>> >> The variable shows up in the list and appears to be saving.
>> >>
>> >> Insert the variable into the document to use it.
>> >>
>> >> Close the doc and reopen.
>> >>
>> >> When the document reopens the variable is not present and is
>> de-referenced in the doc.
>> >>
>> >> This appears to be a critical error. This function is used by many
>> developers along with UNO to published merged documents.
>> >>
>> >> Resolution: Downgrade OpenOffice to <3.4.
>> >>
>>
>> +1 if it's a regression than it's fine for me. Who will take care of
>> this issue?
>>
>> Juergen
>>
>>
>>
>
Re: [RELEASE][3.4.1]Release Bloker: proposing "Bug 119803 - After
upgrading to 3.4 RTF User Fields are not saving"
Posted by Lin Yuan <yu...@gmail.com>.
May related to CWS vmiklos01 which refactor the RTF filter. Seems some
field related processing in sw\source\filter\ww8\rtfattributeoutput.cxx is
not implemented yet. I will do more investigation to know how many codes
need to be added and if it can be contained in 3.4.1 scope.
2012/6/21 Jürgen Schmidt <jo...@googlemail.com>
> On 6/21/12 3:45 AM, YangTerry wrote:
> >
> > Re-send it, seems failed last time.
> >
> > This is a bug about user fields lost after save in RTF file.
> > This is a regression issue, it is work fine in OOo 3.3.
> >> ej197us@gmail.com
> >> 2012-06-07 10:23:13 UTC
> >> To duplicate:
> >> Create a rtf document with a version < 3.4.
> >> Menu Options
> >> Insert
> >> -Field
> >> --Other
> >> ---User Fields
> >>
> >> At this point the variable list is shown.
> >>
> >> Insert a new variable and click the green check.
> >>
> >> The variable shows up in the list and appears to be saving.
> >>
> >> Insert the variable into the document to use it.
> >>
> >> Close the doc and reopen.
> >>
> >> When the document reopens the variable is not present and is
> de-referenced in the doc.
> >>
> >> This appears to be a critical error. This function is used by many
> developers along with UNO to published merged documents.
> >>
> >> Resolution: Downgrade OpenOffice to <3.4.
> >>
>
> +1 if it's a regression than it's fine for me. Who will take care of
> this issue?
>
> Juergen
>
>
>
Re: [RELEASE][3.4.1]Release Bloker: proposing "Bug 119803 - After
upgrading to 3.4 RTF User Fields are not saving"
Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/21/12 3:45 AM, YangTerry wrote:
>
> Re-send it, seems failed last time.
>
> This is a bug about user fields lost after save in RTF file.
> This is a regression issue, it is work fine in OOo 3.3.
>> ej197us@gmail.com
>> 2012-06-07 10:23:13 UTC
>> To duplicate:
>> Create a rtf document with a version < 3.4.
>> Menu Options
>> Insert
>> -Field
>> --Other
>> ---User Fields
>>
>> At this point the variable list is shown.
>>
>> Insert a new variable and click the green check.
>>
>> The variable shows up in the list and appears to be saving.
>>
>> Insert the variable into the document to use it.
>>
>> Close the doc and reopen.
>>
>> When the document reopens the variable is not present and is de-referenced in the doc.
>>
>> This appears to be a critical error. This function is used by many developers along with UNO to published merged documents.
>>
>> Resolution: Downgrade OpenOffice to <3.4.
>>
+1 if it's a regression than it's fine for me. Who will take care of
this issue?
Juergen
RE: [RELEASE][3.4.1]Release Bloker: proposing "Bug 119803 - After
upgrading to 3.4 RTF User Fields are not saving"
Posted by YangTerry <po...@hotmail.com>.
Re-send it, seems failed last time.
This is a bug about user fields lost after save in RTF file.
This is a regression issue, it is work fine in OOo 3.3.
> ej197us@gmail.com
> 2012-06-07 10:23:13 UTC
> To duplicate:
> Create a rtf document with a version < 3.4.
> Menu Options
> Insert
> -Field
> --Other
> ---User Fields
>
> At this point the variable list is shown.
>
> Insert a new variable and click the green check.
>
> The variable shows up in the list and appears to be saving.
>
> Insert the variable into the document to use it.
>
> Close the doc and reopen.
>
> When the document reopens the variable is not present and is de-referenced in the doc.
>
> This appears to be a critical error. This function is used by many developers along with UNO to published merged documents.
>
> Resolution: Downgrade OpenOffice to <3.4.
>
> Thanks,
> Terry Yang
>