You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wayneguow (via GitHub)" <gi...@apache.org> on 2023/02/07 05:29:31 UTC

[GitHub] [spark] wayneguow commented on pull request #39878: [SPARK-42335][SQL] Pass the comment option through to univocity if users set it explicitly in CSV dataSource

wayneguow commented on PR #39878:
URL: https://github.com/apache/spark/pull/39878#issuecomment-1420222944

   Gentle ping @srowen 
   I have made some changes for `isCommentSet `, but it will bring some little differences with before. I put the behavior comparison in a table in [SPARK-42335](https://issues.apache.org/jira/browse/SPARK-42335) 's description. I'm not sure it's worth it.
   
   The best way is to add a `else` condition like parsers after this pr [univocity-parsers#518](https://github.com/uniVocity/univocity-parsers/pull/518) is merged, but univocity-parsers seems to be inactive, there is no any update of for a long time.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org