You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2011/09/14 20:56:09 UTC

[jira] [Commented] (TAP5-1647) PerThreadOperationTracker uses a synchronized block with high thread contention

    [ https://issues.apache.org/jira/browse/TAP5-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104781#comment-13104781 ] 

Hudson commented on TAP5-1647:
------------------------------

Integrated in tapestry-trunk-freestyle #519 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/519/])
    TAP5-1647: Move the call to lock.lock() outside the try ... finally block, as per documentation on ReentrantLock
TAP5-1647: PerThreadOperationTracker uses a synchronized block with high thread contention

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170722
Files : 
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/PerThreadOperationTracker.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PerthreadManagerImpl.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170712
Files : 
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/PerThreadOperationTracker.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PerthreadManagerImpl.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/JDKUtils.java


> PerThreadOperationTracker uses a synchronized block with high thread contention
> -------------------------------------------------------------------------------
>
>                 Key: TAP5-1647
>                 URL: https://issues.apache.org/jira/browse/TAP5-1647
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: performance
>             Fix For: 5.3
>
>
> The synchronized block is there for the same reason as similar code inside PerThreadManagerImpl, but hasn't been worked up the way to remove the synchronization & lock under JDK 1.6.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira