You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/16 23:44:41 UTC

Review Request 44937: GEODE-515 Make sure that we connect to DS using same udp port.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44937/
-----------------------------------------------------------

Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.


Repository: geode


Description
-------

enabled system property for udp port, which is used in product to bind jgroup channel


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java d95d8df 
  geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc 

Diff: https://reviews.apache.org/r/44937/diff/


Testing
-------


Thanks,

Hitesh Khamesra


Re: Review Request 44937: GEODE-515 Make sure that we connect to DS using same udp port.

Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44937/#review123944
-----------------------------------------------------------


Ship it!




Ship It!

- Bruce Schuchardt


On March 16, 2016, 10:44 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44937/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 10:44 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> enabled system property for udp port, which is used in product to bind jgroup channel
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java d95d8df 
>   geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc 
> 
> Diff: https://reviews.apache.org/r/44937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>


Re: Review Request 44937: GEODE-515 Make sure that we connect to DS using same udp port.

Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44937/#review123961
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On March 16, 2016, 10:44 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44937/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 10:44 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> enabled system property for udp port, which is used in product to bind jgroup channel
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java d95d8df 
>   geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc 
> 
> Diff: https://reviews.apache.org/r/44937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>


Re: Review Request 44937: GEODE-515 Make sure that we connect to DS using same udp port.

Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44937/#review123958
-----------------------------------------------------------


Ship it!




Ship It!

- Jianxia Chen


On March 16, 2016, 10:44 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44937/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 10:44 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> enabled system property for udp port, which is used in product to bind jgroup channel
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java d95d8df 
>   geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc 
> 
> Diff: https://reviews.apache.org/r/44937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>