You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Samuelson <pe...@p12n.org> on 2009/08/20 14:46:54 UTC

Re: svn commit: r38878 - trunk/subversion/libsvn_auth_gnome_keyring

[Peter Samuelson]
> +static void
>  init_gnome_keyring(void)
>  {
>    const char *application_name = NULL;
>    application_name = g_get_application_name();
>    if (!application_name)
>      g_set_application_name("Subversion");
> +
> +  /* Ideally we call g_log_set_handler() with a log_domain specific to
> +     libgnome-keyring.  Unfortunately, at least as of gnome-keyring
> +     2.22.3, it doesn't have its own log_domain.  As a result, we
> +     suppress stderr spam for not only libgnome-keyring, but for
> +     anything else the app is linked to that uses glib logging and
> +     doesn't specify a log_domain. */
> +  g_log_set_default_handler(log_noop, NULL);
>  }

An argument could be made that the g_log_set_default_handler call
should happen inside the if (!application_name), on the theory that if
someone has set the GLib application_name, they're a GUI app and would
want their own console spam.

But I don't know enough about it, so I just did what I did.
-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2385641