You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/27 16:45:48 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3614: arch/risc-v: Fix stack alignment according to calling convention

gustavonihei commented on a change in pull request #3614:
URL: https://github.com/apache/incubator-nuttx/pull/3614#discussion_r621404803



##########
File path: arch/risc-v/src/rv32im/riscv_vfork.c
##########
@@ -41,9 +41,9 @@
  * Pre-processor Definitions
  ****************************************************************************/
 
-#ifndef CONFIG_STACK_ALIGNMENT
-#  define CONFIG_STACK_ALIGNMENT 4
-#endif
+/* RISC-V requires a 16-byte stack alignment. */
+
+#define STACK_ALIGNMENT     16

Review comment:
       Thanks, I've removed the unused definition.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org