You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/01/13 00:08:27 UTC
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5703
to review the following change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
11 files changed, 39 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5703/1
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5703
to look at the new patch set (#4).
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
R src/kudu/security/x509_check_host.cc
R src/kudu/security/x509_check_host.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
13 files changed, 45 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5703/4
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/x509_check_host.h
File src/kudu/security/x509_check_host.h:
PS5, Line 12: #ifndef X509_CHECK_HOST_H
: #define X509_CHECK_HOST_H
> After some consideration I don't think it's relevant: corresponding .cc fil
Oh, I see. I thought that we still #included the .h file from socket.cc.
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5703/5//COMMIT_MSG
Commit Message:
PS5, Line 9: Soon these classes will rely on the security module
Is that about RPC-related ones? If so, consider re-phrasing a bit.
http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/ssl_socket.h
File src/kudu/security/ssl_socket.h:
PS5, Line 17: #ifndef KUDU_UTIL_NET_SSL_SOCKET_H
: #define KUDU_UTIL_NET_SSL_SOCKET_H
Since you are replacing include guards with pragma once, consider doing this here as well. Otherwise, consider updating the name of the guard to reflect the new location.
http://gerrit.cloudera.org:8080/#/c/5703/4/src/kudu/security/x509_check_host.cc
File src/kudu/security/x509_check_host.cc:
Line 14: #include <stdio.h>
> I think this was purposefully included after the openssl library, and used
This file is not going to be compiled in case of the newer version of the OpenSSL library, so it's not relevant.
http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/x509_check_host.h
File src/kudu/security/x509_check_host.h:
PS5, Line 12: #ifndef X509_CHECK_HOST_H
: #define X509_CHECK_HOST_H
Is this intentionally set to X509_CHECK_HOST_H to be the same as the guard in some other OpenSSL file? If not, consider replacing with pragma once.
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5703/4/src/kudu/security/x509_check_host.cc
File src/kudu/security/x509_check_host.cc:
Line 14: #include "kudu/security/x509_check_host.h"
> I think this was purposefully included after the openssl library, and used
Done
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5703
to look at the new patch set (#6).
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
R src/kudu/security/x509_check_host.cc
R src/kudu/security/x509_check_host.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
13 files changed, 47 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5703/6
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5703/4/src/kudu/security/x509_check_host.cc
File src/kudu/security/x509_check_host.cc:
Line 14: #include "kudu/security/x509_check_host.h"
I think this was purposefully included after the openssl library, and used the same include guards, so that it won't double-declare it on versions of ssl which supported x509_check_host
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Reviewed-on: http://gerrit.cloudera.org:8080/5703
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
R src/kudu/security/x509_check_host.cc
R src/kudu/security/x509_check_host.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
13 files changed, 47 insertions(+), 44 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5703
to look at the new patch set (#2).
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
R src/kudu/security/x509_check_host.cc
R src/kudu/security/x509_check_host.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
13 files changed, 42 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5703/2
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/x509_check_host.h
File src/kudu/security/x509_check_host.h:
PS5, Line 12: #ifndef X509_CHECK_HOST_H
: #define X509_CHECK_HOST_H
> Yes, according to Todd it is.
After some consideration I don't think it's relevant: corresponding .cc file is not compiled at all for newer version of the SSL library, so this include guard can be anything.
But it's not crucial.
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5703
to look at the new patch set (#5).
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
R src/kudu/security/x509_check_host.cc
R src/kudu/security/x509_check_host.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
13 files changed, 44 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5703/5
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5703/5//COMMIT_MSG
Commit Message:
PS5, Line 9: Soon these classes will rely on the security module
> Is that about RPC-related ones? If so, consider re-phrasing a bit.
No, it's referring to SSLFactory and SSLSocket.
http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/ssl_socket.h
File src/kudu/security/ssl_socket.h:
PS5, Line 17: #ifndef KUDU_UTIL_NET_SSL_SOCKET_H
: #define KUDU_UTIL_NET_SSL_SOCKET_H
> Since you are replacing include guards with pragma once, consider doing thi
Done
http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/x509_check_host.h
File src/kudu/security/x509_check_host.h:
PS5, Line 12: #ifndef X509_CHECK_HOST_H
: #define X509_CHECK_HOST_H
> Is this intentionally set to X509_CHECK_HOST_H to be the same as the guard
Yes, according to Todd it is.
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Move SSLFactory and SSLSocket to the security module
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5703
to look at the new patch set (#3).
Change subject: Move SSLFactory and SSLSocket to the security module
......................................................................
Move SSLFactory and SSLSocket to the security module
Soon these classes will rely on the security module, so to avoid cyclic
dependencies they must be moved.
Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
---
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/reactor.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ssl_factory.cc
R src/kudu/security/ssl_factory.h
R src/kudu/security/ssl_socket.cc
R src/kudu/security/ssl_socket.h
R src/kudu/security/x509_check_host.cc
R src/kudu/security/x509_check_host.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/net_util-test.cc
13 files changed, 44 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5703/3
--
To view, visit http://gerrit.cloudera.org:8080/5703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>