You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/12/11 23:04:12 UTC

[PR] Use the latest version of Maven in build [maven-jenkins-lib]

slawekjaranowski opened a new pull request, #9:
URL: https://github.com/apache/maven-jenkins-lib/pull/9

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use the latest version of Maven in build [maven-jenkins-lib]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #9:
URL: https://github.com/apache/maven-jenkins-lib/pull/9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use the latest version of Maven in build [maven-jenkins-lib]

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #9:
URL: https://github.com/apache/maven-jenkins-lib/pull/9#discussion_r1423247005


##########
vars/asfMavenTlpPlgnBuild.groovy:
##########
@@ -40,12 +40,12 @@ def call(Map params = [:]) {
     // minimum, LTS, current and next ea
     def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17']
     def jdkMin = jdks[0];
-    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.8.x']
+    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.x.x']

Review Comment:
   the naming is really weird.. shouldn’t we have something such `3.9.x`? 



##########
vars/asfMavenTlpPlgnBuild.groovy:
##########
@@ -40,12 +40,12 @@ def call(Map params = [:]) {
     // minimum, LTS, current and next ea
     def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17']
     def jdkMin = jdks[0];
-    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.8.x']
+    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.x.x']

Review Comment:
   the naming is really weird.. shouldn’t we have something such `3.9.x`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use the latest version of Maven in build [maven-jenkins-lib]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #9:
URL: https://github.com/apache/maven-jenkins-lib/pull/9#discussion_r1423476222


##########
vars/asfMavenTlpPlgnBuild.groovy:
##########
@@ -40,12 +40,12 @@ def call(Map params = [:]) {
     // minimum, LTS, current and next ea
     def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17']
     def jdkMin = jdks[0];
-    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.8.x']
+    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.x.x']

Review Comment:
   can be 😄 



##########
vars/asfMavenTlpPlgnBuild.groovy:
##########
@@ -40,12 +40,12 @@ def call(Map params = [:]) {
     // minimum, LTS, current and next ea
     def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17']
     def jdkMin = jdks[0];
-    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.8.x']
+    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.x.x']

Review Comment:
   can be 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use the latest version of Maven in build [maven-jenkins-lib]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #9:
URL: https://github.com/apache/maven-jenkins-lib/pull/9#discussion_r1423483733


##########
vars/asfMavenTlpPlgnBuild.groovy:
##########
@@ -40,12 +40,12 @@ def call(Map params = [:]) {
     // minimum, LTS, current and next ea
     def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17']
     def jdkMin = jdks[0];
-    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.8.x']
+    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x', '3.x.x']

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org