[GitHub] [kafka] liukrimhrim commented on pull request #8630: KAFKA-9969: Exclude ConnectorClientConfigRequest from class loading isolation

[GitBox <gi...@apache.org>]

liukrimhrim commented on pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#issuecomment-626269096


   > I've refactored the `PluginUtilsTest` to include more cases, and discovered one discrepancy for the `basic-auth-extension`.
   > 
   > Based on the pattern from the other modules under `connect/` like `transforms`, I would assume that all of the classes in that module would be isolated by default. This does not appear to be the case:
   > 
   > * `org.apache.kafka.connect.rest.basic.auth.extension.BasicAuthSecurityRestExtension` is correctly loaded in isolation
   > * `org.apache.kafka.connect.rest.basic.auth.extension.JaasBasicAuthFilter` is not loaded in isolation but should be
   > * `org.apache.kafka.connect.rest.basic.auth.extension.PropertyFileLoginModule` is not loaded in isolation but should be
   > 
   > I've left the two classes which do not meet my expectations commented out in the test. I'm not sure what the intended isolation behavior in this case should be.
   
   Do we have a principle to deduce which class should be loaded in isolation, and which should not? Or is it completely a guess based on experience (if a class is a dep only for plugins, it will be fine to load in isolation)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org