You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/01/30 13:04:19 UTC
Review Request 56076: AMBARI-19775. ActionQueue thread may exit due to
IOError in statusCommandResultQueue.empty()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19775
https://issues.apache.org/jira/browse/AMBARI-19775
Repository: ambari
Description
-------
Handle IOError thrown from empty()
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 18d7c2afd20279fe6586b3235dcd668aabeeb7fb
Diff: https://reviews.apache.org/r/56076/diff/
Testing
-------
Manual testing: simulated IOError, verified heartbeat continues to include status command results.
Thanks,
Attila Doroszlai
Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit
due to IOError in statusCommandResultQueue.empty()
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/#review163511
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 30, 2017, 2:04 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56076/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 2:04 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19775
> https://issues.apache.org/jira/browse/AMBARI-19775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Handle IOError thrown from empty()
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 18d7c2afd20279fe6586b3235dcd668aabeeb7fb
>
> Diff: https://reviews.apache.org/r/56076/diff/
>
>
> Testing
> -------
>
> Manual testing: simulated IOError, verified heartbeat continues to include status command results.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit
due to IOError in statusCommandResultQueue.empty()
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/#review163512
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Jan. 30, 2017, 1:04 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56076/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 1:04 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19775
> https://issues.apache.org/jira/browse/AMBARI-19775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Handle IOError thrown from empty()
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 18d7c2afd20279fe6586b3235dcd668aabeeb7fb
>
> Diff: https://reviews.apache.org/r/56076/diff/
>
>
> Testing
> -------
>
> Manual testing: simulated IOError, verified heartbeat continues to include status command results.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit
due to IOError in statusCommandResultQueue.empty()
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/#review163507
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Jan. 30, 2017, 1:04 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56076/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 1:04 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19775
> https://issues.apache.org/jira/browse/AMBARI-19775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Handle IOError thrown from empty()
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 18d7c2afd20279fe6586b3235dcd668aabeeb7fb
>
> Diff: https://reviews.apache.org/r/56076/diff/
>
>
> Testing
> -------
>
> Manual testing: simulated IOError, verified heartbeat continues to include status command results.
>
>
> Thanks,
>
> Attila Doroszlai
>
>