You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "Henry-Hong (via GitHub)" <gi...@apache.org> on 2024/08/11 05:54:35 UTC
[PR] Fix(zeppelin-web): downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Henry-Hong opened a new pull request, #4786:
URL: https://github.com/apache/zeppelin/pull/4786
### What is this PR for?
Overview
---
When using markdown interpreter, It supposed to support [mathematical format](https://zeppelin.apache.org/docs/latest/usage/display_system/basic.html#mathematical-expressions).
But loading MathJax(JS lib for mathematical formatting) was failed.
Background
---
In the build process of zeppelin-web project, a Grunt task named copy is used to transfer files from one directory to another. This task is important for ensuring that necessary files, particularly those within node_modules, are correctly placed where they are needed.
<img width="500" alt="image" src="https://github.com/user-attachments/assets/a8983447-4c14-4114-8ecf-3453b807fc53">
_(zeppelin-web/Gruntfile.js)_
However, an issue has arisen where files from the node_modules/MathJax/** directory were not being copied as expected. Upon investigation, it was found that this was due to a change in the directory structure of MathJax after upgrading from version 2.7.9 to 3.0.0, as managed by Dependabot. (8de680402711681c16a2aefb2f737bc5aa050d78)
<img width="666" alt="image" src="https://github.com/user-attachments/assets/074ef9d6-ba17-4ff0-9ebc-fbbf12846035">
Resolution
---
To address this issue, the following steps were taken:
- Downgrade the dependency MathJax version from 3.0.0 to 2.7.9 to maintain compatibility with the directory structure expected by `Gruntfile.js`.
- Ensured that the copy task in Grunt is correctly mapping and copying the files from the updated MathJax directory.
As-Is
---
<img width="400" alt="as-is" src="https://github.com/user-attachments/assets/d079f5ee-4238-4f1c-9dba-7fb365b173c9">
To-Be
---
<img width="400" alt="to-be" src="https://github.com/user-attachments/assets/b546b944-febd-4a46-95e8-5516a2cc8ee8">
### What type of PR is it?
Bug Fix
### Todos
* [x] Downgrade MathJax from 3.0.0 to 2.7.9
* [ ] Add Tests
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6046
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786#issuecomment-2285463273
>I'm generally not a fan of downgrades, at some point old versions are no longer supported and the update has to be done.
Do you see a possibility to adapt the Gruntfile and the index.html accordingly so that mathjax works in version 3.x?
@Reamer I agree with avoiding a downgrade. However, we could use two different steps. As a workaround, we revert this change to the old stable one and will try to upgrade it. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786#issuecomment-2283376035
I'm generally not a fan of downgrades, at some point old versions are no longer supported and the update has to be done.
Do you see a possibility to adapt the `Gruntfile` and the `index.html` accordingly so that mathjax works in version 3.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786#issuecomment-2285484793
@Reamer Created. https://issues.apache.org/jira/browse/ZEPPELIN-6056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786#issuecomment-2285474298
@jongyoul
Yes, we can do a downgrade to restore the functionality. Could you open a JIRA ticket to update MathJX with the findings in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer merged PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "Henry-Hong (via GitHub)" <gi...@apache.org>.
Henry-Hong commented on PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786#issuecomment-2286109498
> @Henry-Hong This PR needs a rebase
Sorry for being late! rebased and force pushed again! Please take a look plz.
@Reamer @jongyoul
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6046] Fix(zeppelin-web): Downgrade mathjax (3.0.0 -> 2.7.9) [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4786:
URL: https://github.com/apache/zeppelin/pull/4786#issuecomment-2285563915
@Henry-Hong This PR needs a rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org