[GitHub] [kafka] abbccdda commented on a change in pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

[GitBox <gi...@apache.org>]

abbccdda commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r432901618



##########
File path: streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -711,6 +715,56 @@ public void shouldUseSourceSpecificDeserializers() {
         assertThat(result2.getValue(), equalTo(source2Value));
     }
 
+    @Test
+    public void shouldPassRecordHeadersIntoDeSerializers() {

Review comment:
       It seems like we are just verifying the headers are deserialized. Should we just use mock deserializers? Moreover, we could build a customized `boolean` deserializer which outputs true when the header is provided, or false otherwise.

##########
File path: streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -711,6 +715,56 @@ public void shouldUseSourceSpecificDeserializers() {
         assertThat(result2.getValue(), equalTo(source2Value));
     }
 
+    @Test
+    public void shouldPassRecordHeadersIntoDeSerializers() {

Review comment:
       DeSerializers -> Deserializers




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org