You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/08 12:31:30 UTC
[GitHub] [flink] luoyuxia opened a new pull request, #20501: Catalog get statistics by partitions
luoyuxia opened a new pull request, #20501:
URL: https://github.com/apache/flink/pull/20501
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #20501: Catalog get statistics by partitions
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on PR #20501:
URL: https://github.com/apache/flink/pull/20501#issuecomment-1208106392
Please refer https://github.com/apache/flink/pull/20422 to see the previous comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20501: [FLINK-28778][SQL/API] Bulk fetch of table and column statistics for given partitions
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20501:
URL: https://github.com/apache/flink/pull/20501#discussion_r940951883
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java:
##########
@@ -90,6 +102,257 @@ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogColumnSt
return colStats;
}
+ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogPartitionColumnStats(
+ HiveMetastoreClientWrapper client,
+ HiveShim hiveShim,
+ Table hiveTable,
+ String partitionName,
+ List<FieldSchema> partitionColsSchema,
+ String defaultPartitionName) {
+ Map<String, CatalogColumnStatisticsDataBase> partitionColumnStats = new HashMap<>();
+ List<String> partitionCols = new ArrayList<>(partitionColsSchema.size());
+ List<LogicalType> partitionColsType = new ArrayList<>(partitionColsSchema.size());
+ for (FieldSchema fieldSchema : partitionColsSchema) {
+ partitionCols.add(fieldSchema.getName());
+ partitionColsType.add(
+ HiveTypeUtil.toFlinkType(
+ TypeInfoUtils.getTypeInfoFromTypeString(fieldSchema.getType()))
+ .getLogicalType());
+ }
+
+ // the partition column and values for the partition column
+ Map<String, Object> partitionColValues = new HashMap<>();
+ CatalogPartitionSpec partitionSpec =
+ HivePartitionUtils.createPartitionSpec(partitionName, defaultPartitionName);
+ for (int i = 0; i < partitionCols.size(); i++) {
+ String partitionCol = partitionCols.get(i);
+ String partitionStrVal = partitionSpec.getPartitionSpec().get(partitionCols.get(i));
+ if (partitionStrVal == null) {
+ partitionColValues.put(partitionCol, null);
+ } else {
+ partitionColValues.put(
+ partitionCol,
+ HivePartitionUtils.restorePartitionValueFromType(
+ hiveShim,
+ partitionStrVal,
+ partitionColsType.get(i),
+ defaultPartitionName));
+ }
+ }
+
+ // calculate statistic for each partition column
+ for (int i = 0; i < partitionCols.size(); i++) {
+ Object partitionValue = partitionColValues.get(partitionCols.get(i));
+ LogicalType logicalType = partitionColsType.get(i);
+ CatalogColumnStatisticsDataBase catalogColumnStatistics =
+ getColumnStatistics(
+ client,
+ hiveTable,
+ logicalType,
+ partitionValue,
+ i,
+ defaultPartitionName);
+ if (catalogColumnStatistics != null) {
+ partitionColumnStats.put(partitionCols.get(i), catalogColumnStatistics);
+ }
+ }
+
+ return partitionColumnStats;
+ }
+
+ /**
+ * Get statistics for specific partition column.
+ *
+ * @param logicalType the specific partition column's logical type
+ * @param partitionValue the partition value for the specific partition column
+ * @param partitionColIndex the index of the specific partition
+ * @param defaultPartitionName the default partition name for null value
+ */
+ private static CatalogColumnStatisticsDataBase getColumnStatistics(
+ HiveMetastoreClientWrapper client,
+ Table hiveTable,
+ LogicalType logicalType,
+ Object partitionValue,
+ int partitionColIndex,
+ String defaultPartitionName) {
+ switch (logicalType.getTypeRoot()) {
+ case CHAR:
+ case VARCHAR:
+ {
+ Long maxLength = null;
+ Double avgLength = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ long valLength = ((String) partitionValue).length();
+ maxLength = valLength;
+ avgLength = (double) valLength;
+ }
+ return new CatalogColumnStatisticsDataString(
+ maxLength, avgLength, 1L, nullCount);
+ }
+ case BOOLEAN:
+ {
+ long trueCount = 0L;
+ long falseCount = 0L;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ Boolean boolVal = (Boolean) partitionValue;
+ if (boolVal) {
+ trueCount = 1L;
+ } else {
+ falseCount = 1L;
+ }
+ }
+ return new CatalogColumnStatisticsDataBoolean(trueCount, falseCount, nullCount);
+ }
+ case TINYINT:
+ case SMALLINT:
+ case INTEGER:
+ case BIGINT:
+ {
+ Long min = null;
+ Long max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = ((Number) partitionValue).longValue();
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataLong(min, max, 1L, nullCount);
+ }
+ case FLOAT:
+ case DOUBLE:
+ case DECIMAL:
+ {
+ Double min = null;
+ Double max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = ((Number) partitionValue).doubleValue();
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataDouble(min, max, 1L, nullCount);
+ }
+ case DATE:
+ {
+ Date min = null;
+ Date max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = new Date(((LocalDate) partitionValue).toEpochDay());
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataDate(min, max, 1L, nullCount);
+ }
+ default:
+ return null;
Review Comment:
Miss it. `TIMESTAMP` should be supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #20501: [FLINK-28778][SQL/API] Bulk fetch of table and column statistics for given partitions
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #20501: [FLINK-28778][SQL/API] Bulk fetch of table and column statistics for given partitions
URL: https://github.com/apache/flink/pull/20501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20501: Catalog get statistics by partitions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20501:
URL: https://github.com/apache/flink/pull/20501#issuecomment-1208102296
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ca1d2ef582867cd4715408213af0006e9bac63d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca1d2ef582867cd4715408213af0006e9bac63d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca1d2ef582867cd4715408213af0006e9bac63d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #20501: [FLINK-28778][SQL/API] Bulk fetch of table and column statistics for given partitions
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on PR #20501:
URL: https://github.com/apache/flink/pull/20501#issuecomment-1209456374
The failure test is due to https://issues.apache.org/jira/browse/FLINK-28844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a diff in pull request #20501: Catalog get statistics by partitions
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on code in PR #20501:
URL: https://github.com/apache/flink/pull/20501#discussion_r940832517
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java:
##########
@@ -90,6 +102,257 @@ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogColumnSt
return colStats;
}
+ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogPartitionColumnStats(
+ HiveMetastoreClientWrapper client,
+ HiveShim hiveShim,
+ Table hiveTable,
+ String partitionName,
+ List<FieldSchema> partitionColsSchema,
+ String defaultPartitionName) {
+ Map<String, CatalogColumnStatisticsDataBase> partitionColumnStats = new HashMap<>();
+ List<String> partitionCols = new ArrayList<>(partitionColsSchema.size());
+ List<LogicalType> partitionColsType = new ArrayList<>(partitionColsSchema.size());
+ for (FieldSchema fieldSchema : partitionColsSchema) {
+ partitionCols.add(fieldSchema.getName());
+ partitionColsType.add(
+ HiveTypeUtil.toFlinkType(
+ TypeInfoUtils.getTypeInfoFromTypeString(fieldSchema.getType()))
+ .getLogicalType());
+ }
+
+ // the partition column and values for the partition column
+ Map<String, Object> partitionColValues = new HashMap<>();
+ CatalogPartitionSpec partitionSpec =
+ HivePartitionUtils.createPartitionSpec(partitionName, defaultPartitionName);
+ for (int i = 0; i < partitionCols.size(); i++) {
+ String partitionCol = partitionCols.get(i);
+ String partitionStrVal = partitionSpec.getPartitionSpec().get(partitionCols.get(i));
+ if (partitionStrVal == null) {
+ partitionColValues.put(partitionCol, null);
+ } else {
+ partitionColValues.put(
+ partitionCol,
+ HivePartitionUtils.restorePartitionValueFromType(
+ hiveShim,
+ partitionStrVal,
+ partitionColsType.get(i),
+ defaultPartitionName));
+ }
+ }
+
+ // calculate statistic for each partition column
+ for (int i = 0; i < partitionCols.size(); i++) {
+ Object partitionValue = partitionColValues.get(partitionCols.get(i));
+ LogicalType logicalType = partitionColsType.get(i);
+ CatalogColumnStatisticsDataBase catalogColumnStatistics =
+ getColumnStatistics(
+ client,
+ hiveTable,
+ logicalType,
+ partitionValue,
+ i,
+ defaultPartitionName);
+ if (catalogColumnStatistics != null) {
+ partitionColumnStats.put(partitionCols.get(i), catalogColumnStatistics);
+ }
+ }
+
+ return partitionColumnStats;
+ }
+
+ /**
+ * Get statistics for specific partition column.
+ *
+ * @param logicalType the specific partition column's logical type
+ * @param partitionValue the partition value for the specific partition column
+ * @param partitionColIndex the index of the specific partition
+ * @param defaultPartitionName the default partition name for null value
+ */
+ private static CatalogColumnStatisticsDataBase getColumnStatistics(
+ HiveMetastoreClientWrapper client,
+ Table hiveTable,
+ LogicalType logicalType,
+ Object partitionValue,
+ int partitionColIndex,
+ String defaultPartitionName) {
+ switch (logicalType.getTypeRoot()) {
+ case CHAR:
+ case VARCHAR:
+ {
+ Long maxLength = null;
+ Double avgLength = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ long valLength = ((String) partitionValue).length();
+ maxLength = valLength;
+ avgLength = (double) valLength;
+ }
+ return new CatalogColumnStatisticsDataString(
+ maxLength, avgLength, 1L, nullCount);
+ }
+ case BOOLEAN:
+ {
+ long trueCount = 0L;
+ long falseCount = 0L;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ Boolean boolVal = (Boolean) partitionValue;
+ if (boolVal) {
+ trueCount = 1L;
+ } else {
+ falseCount = 1L;
+ }
+ }
+ return new CatalogColumnStatisticsDataBoolean(trueCount, falseCount, nullCount);
+ }
+ case TINYINT:
+ case SMALLINT:
+ case INTEGER:
+ case BIGINT:
+ {
+ Long min = null;
+ Long max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = ((Number) partitionValue).longValue();
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataLong(min, max, 1L, nullCount);
+ }
+ case FLOAT:
+ case DOUBLE:
+ case DECIMAL:
+ {
+ Double min = null;
+ Double max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = ((Number) partitionValue).doubleValue();
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataDouble(min, max, 1L, nullCount);
+ }
+ case DATE:
+ {
+ Date min = null;
+ Date max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = new Date(((LocalDate) partitionValue).toEpochDay());
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataDate(min, max, 1L, nullCount);
+ }
+ default:
+ return null;
Review Comment:
TIMESTAMP is unsupported ?
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java:
##########
@@ -90,6 +102,257 @@ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogColumnSt
return colStats;
}
+ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogPartitionColumnStats(
+ HiveMetastoreClientWrapper client,
+ HiveShim hiveShim,
+ Table hiveTable,
+ String partitionName,
+ List<FieldSchema> partitionColsSchema,
+ String defaultPartitionName) {
+ Map<String, CatalogColumnStatisticsDataBase> partitionColumnStats = new HashMap<>();
+ List<String> partitionCols = new ArrayList<>(partitionColsSchema.size());
+ List<LogicalType> partitionColsType = new ArrayList<>(partitionColsSchema.size());
+ for (FieldSchema fieldSchema : partitionColsSchema) {
+ partitionCols.add(fieldSchema.getName());
+ partitionColsType.add(
+ HiveTypeUtil.toFlinkType(
+ TypeInfoUtils.getTypeInfoFromTypeString(fieldSchema.getType()))
+ .getLogicalType());
+ }
+
+ // the partition column and values for the partition column
+ Map<String, Object> partitionColValues = new HashMap<>();
+ CatalogPartitionSpec partitionSpec =
+ HivePartitionUtils.createPartitionSpec(partitionName, defaultPartitionName);
+ for (int i = 0; i < partitionCols.size(); i++) {
+ String partitionCol = partitionCols.get(i);
+ String partitionStrVal = partitionSpec.getPartitionSpec().get(partitionCols.get(i));
+ if (partitionStrVal == null) {
+ partitionColValues.put(partitionCol, null);
+ } else {
+ partitionColValues.put(
+ partitionCol,
+ HivePartitionUtils.restorePartitionValueFromType(
+ hiveShim,
+ partitionStrVal,
+ partitionColsType.get(i),
+ defaultPartitionName));
+ }
+ }
+
+ // calculate statistic for each partition column
+ for (int i = 0; i < partitionCols.size(); i++) {
+ Object partitionValue = partitionColValues.get(partitionCols.get(i));
+ LogicalType logicalType = partitionColsType.get(i);
+ CatalogColumnStatisticsDataBase catalogColumnStatistics =
+ getColumnStatistics(
+ client,
+ hiveTable,
+ logicalType,
+ partitionValue,
+ i,
+ defaultPartitionName);
+ if (catalogColumnStatistics != null) {
+ partitionColumnStats.put(partitionCols.get(i), catalogColumnStatistics);
+ }
+ }
+
+ return partitionColumnStats;
+ }
+
+ /**
+ * Get statistics for specific partition column.
+ *
+ * @param logicalType the specific partition column's logical type
+ * @param partitionValue the partition value for the specific partition column
+ * @param partitionColIndex the index of the specific partition
+ * @param defaultPartitionName the default partition name for null value
+ */
+ private static CatalogColumnStatisticsDataBase getColumnStatistics(
Review Comment:
how about `getPartitionColumnStats` ?
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java:
##########
@@ -90,6 +102,257 @@ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogColumnSt
return colStats;
}
+ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogPartitionColumnStats(
Review Comment:
getCatalogPartitionColumnStats ?
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/stats/CatalogTableStatistics.java:
##########
@@ -27,8 +27,11 @@
/** Statistics for a non-partitioned table or a partition of a partitioned table. */
@PublicEvolving
public class CatalogTableStatistics {
+
public static final CatalogTableStatistics UNKNOWN = new CatalogTableStatistics(-1, -1, -1, -1);
+ public static final CatalogTableStatistics EMPTY = new CatalogTableStatistics(0, 0, 0, 0);
Review Comment:
useless line, remove
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java:
##########
@@ -90,6 +102,257 @@ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogColumnSt
return colStats;
}
+ public static Map<String, CatalogColumnStatisticsDataBase> createCatalogPartitionColumnStats(
+ HiveMetastoreClientWrapper client,
+ HiveShim hiveShim,
+ Table hiveTable,
+ String partitionName,
+ List<FieldSchema> partitionColsSchema,
+ String defaultPartitionName) {
+ Map<String, CatalogColumnStatisticsDataBase> partitionColumnStats = new HashMap<>();
+ List<String> partitionCols = new ArrayList<>(partitionColsSchema.size());
+ List<LogicalType> partitionColsType = new ArrayList<>(partitionColsSchema.size());
+ for (FieldSchema fieldSchema : partitionColsSchema) {
+ partitionCols.add(fieldSchema.getName());
+ partitionColsType.add(
+ HiveTypeUtil.toFlinkType(
+ TypeInfoUtils.getTypeInfoFromTypeString(fieldSchema.getType()))
+ .getLogicalType());
+ }
+
+ // the partition column and values for the partition column
+ Map<String, Object> partitionColValues = new HashMap<>();
+ CatalogPartitionSpec partitionSpec =
+ HivePartitionUtils.createPartitionSpec(partitionName, defaultPartitionName);
+ for (int i = 0; i < partitionCols.size(); i++) {
+ String partitionCol = partitionCols.get(i);
+ String partitionStrVal = partitionSpec.getPartitionSpec().get(partitionCols.get(i));
+ if (partitionStrVal == null) {
+ partitionColValues.put(partitionCol, null);
+ } else {
+ partitionColValues.put(
+ partitionCol,
+ HivePartitionUtils.restorePartitionValueFromType(
+ hiveShim,
+ partitionStrVal,
+ partitionColsType.get(i),
+ defaultPartitionName));
+ }
+ }
+
+ // calculate statistic for each partition column
+ for (int i = 0; i < partitionCols.size(); i++) {
+ Object partitionValue = partitionColValues.get(partitionCols.get(i));
+ LogicalType logicalType = partitionColsType.get(i);
+ CatalogColumnStatisticsDataBase catalogColumnStatistics =
+ getColumnStatistics(
+ client,
+ hiveTable,
+ logicalType,
+ partitionValue,
+ i,
+ defaultPartitionName);
+ if (catalogColumnStatistics != null) {
+ partitionColumnStats.put(partitionCols.get(i), catalogColumnStatistics);
+ }
+ }
+
+ return partitionColumnStats;
+ }
+
+ /**
+ * Get statistics for specific partition column.
+ *
+ * @param logicalType the specific partition column's logical type
+ * @param partitionValue the partition value for the specific partition column
+ * @param partitionColIndex the index of the specific partition
+ * @param defaultPartitionName the default partition name for null value
+ */
+ private static CatalogColumnStatisticsDataBase getColumnStatistics(
+ HiveMetastoreClientWrapper client,
+ Table hiveTable,
+ LogicalType logicalType,
+ Object partitionValue,
+ int partitionColIndex,
+ String defaultPartitionName) {
+ switch (logicalType.getTypeRoot()) {
+ case CHAR:
+ case VARCHAR:
+ {
+ Long maxLength = null;
+ Double avgLength = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ long valLength = ((String) partitionValue).length();
+ maxLength = valLength;
+ avgLength = (double) valLength;
+ }
+ return new CatalogColumnStatisticsDataString(
+ maxLength, avgLength, 1L, nullCount);
+ }
+ case BOOLEAN:
+ {
+ long trueCount = 0L;
+ long falseCount = 0L;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ Boolean boolVal = (Boolean) partitionValue;
+ if (boolVal) {
+ trueCount = 1L;
+ } else {
+ falseCount = 1L;
+ }
+ }
+ return new CatalogColumnStatisticsDataBoolean(trueCount, falseCount, nullCount);
+ }
+ case TINYINT:
+ case SMALLINT:
+ case INTEGER:
+ case BIGINT:
+ {
+ Long min = null;
+ Long max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = ((Number) partitionValue).longValue();
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataLong(min, max, 1L, nullCount);
+ }
+ case FLOAT:
+ case DOUBLE:
+ case DECIMAL:
+ {
+ Double min = null;
+ Double max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = ((Number) partitionValue).doubleValue();
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataDouble(min, max, 1L, nullCount);
+ }
+ case DATE:
+ {
+ Date min = null;
+ Date max = null;
+ Long nullCount = 0L;
+ if (partitionValue == null) {
+ nullCount =
+ getNullCount(
+ client, hiveTable, partitionColIndex, defaultPartitionName);
+ } else {
+ min = new Date(((LocalDate) partitionValue).toEpochDay());
+ max = min;
+ }
+ return new CatalogColumnStatisticsDataDate(min, max, 1L, nullCount);
+ }
+ default:
+ return null;
+ }
+ }
+
+ /**
+ * Get the null count for the {@param partitionColIndex} partition column in table {@param
+ * hiveTable}.
+ *
+ * <p>To get the null count, it will first list all the partitions whose {@param
+ * partitionColIndex} partition column is null, and merge the partition's statistic to get the
+ * total rows, which is exactly null count for the {@param partitionColIndex} partition column.
+ */
+ private static Long getNullCount(
Review Comment:
getPartitionColumnNullCount
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20501: [FLINK-28778][SQL/API] Bulk fetch of table and column statistics for given partitions
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20501:
URL: https://github.com/apache/flink/pull/20501#issuecomment-1208973074
@godfreyhe Thanks for your review. I have addressed all your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org