[GitHub] [pulsar] congbobo184 opened a new pull request #10146: [Transaction] Fix transaction log recover fail problem.

[GitBox <gi...@apache.org>]

congbobo184 opened a new pull request #10146:
URL: https://github.com/apache/pulsar/pull/10146


   ## Motivation
   Now transaction log recover by compare ```lastConfirmedEntry.compareTo(currentLoadPosition) > 0```, when the ```lastConfirmedEntry``` has acked by cursor, we can't change the currentLoadPosition to ```lastConfirmedEntry``` or  ```lastConfirmedEntry ``` + 1, so we should judge the ```cursor.hasMoreEntries()``` and ```entryQueue.size()```
   
   ## implement
   judge the ```cursor.hasMoreEntries()``` and ```entryQueue.size()``` to recover
   ### Verifying this change
   Add the tests for it
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (no)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10146: [Transaction] Fix transaction log recover fail problem.

[GitBox <gi...@apache.org>]

codelipenghui merged pull request #10146:
URL: https://github.com/apache/pulsar/pull/10146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org