You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 12:53:25 UTC
[GitHub] [airflow] olchas opened a new pull request #10506: Improve direct impersonation documentation
olchas opened a new pull request #10506:
URL: https://github.com/apache/airflow/pull/10506
This PR adds a few additional info to the documentation of direct impersonation in Google operators. Part-of https://github.com/apache/airflow/issues/8803
- different name of `impersonation_chain` argument in case of operators that also communicate with other cloud provider (`google_impersonation_chain`)
- warning about no support for`GKEStartPodOperator`, `DataflowCreateJavaJobOperator` and `DataflowCreatePythonJobOperator` as of now
- additional info about behavior in case of operators that connect to multiple Google services
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas commented on a change in pull request #10506: Improve direct impersonation documentation
Posted by GitBox <gi...@apache.org>.
olchas commented on a change in pull request #10506:
URL: https://github.com/apache/airflow/pull/10506#discussion_r475640446
##########
File path: docs/howto/connection/gcp.rst
##########
@@ -132,9 +133,15 @@ In order for this example to work, the account ``impersonated_account`` must gra
access token, which will allow to act on its behalf using its permissions. ``impersonated_account``
does not even need to have a generated key.
-You can even impersonate accounts from projects other than the project of the originating account.
-In that case, the project id of the impersonated account will be used as the default project id in
-operators logic, unless you have explicitly specified the Project Id in Connection's configuration.
+.. warning::
+ GKEStartPodOperator, DataflowCreateJavaJobOperator and DataflowCreatePythonJobOperator do not
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10506: Improve direct impersonation documentation
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10506:
URL: https://github.com/apache/airflow/pull/10506#discussion_r475591727
##########
File path: docs/howto/connection/gcp.rst
##########
@@ -132,9 +133,15 @@ In order for this example to work, the account ``impersonated_account`` must gra
access token, which will allow to act on its behalf using its permissions. ``impersonated_account``
does not even need to have a generated key.
-You can even impersonate accounts from projects other than the project of the originating account.
-In that case, the project id of the impersonated account will be used as the default project id in
-operators logic, unless you have explicitly specified the Project Id in Connection's configuration.
+.. warning::
+ GKEStartPodOperator, DataflowCreateJavaJobOperator and DataflowCreatePythonJobOperator do not
Review comment:
Can you add refernece to cllass here?
```
* :class:`~airflow.providers..`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10506: Improve direct impersonation documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10506:
URL: https://github.com/apache/airflow/pull/10506
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org