You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Paul Bors <pa...@bors.ws> on 2013/12/05 17:24:39 UTC
Wrong JavaDoc for FeedbackMessages#hasMessage(int)
Currently (as of 6.10.0) the JavaDoc on
the FeedbackMessages#hasMessage(int) states that it returns true if and
only if a message with the specified level was registered.
However it relies on FeedbackMessage#isLevel(int) which in turn return true
if whether the message level is greater than or equal to the given level.
Isn't that contradicting? I registered an Error message for my form field
and I have a new behavior checking for Warnings that performs its duties
because an Error message is at a lever greater than the Warning level.
~ Thank you,
Paul Bors
Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)
Posted by Paul Bors <pa...@bors.ws>.
We should still edit the JavaDoc for FeedbackMessages#hasMessage(int) and
instruct to use ExactLevelFeedbackMessageFilter.
Otherwise might get confused if the don't review the implementation.
~ Thank you,
Paul Bors
On Fri, Dec 6, 2013 at 4:11 AM, Martin Grigorov <mg...@apache.org>wrote:
> I've backported ExactLevelFeedbackMessageFilter from master branch.
>
> It has been introduced for:
> WICKET-4585 WicketTester.assertErrorMessages passes even if the message
> isn't visible on the page
> WICKET-5128 Allow for Testing Component relative Feedback-Messages in
> Wicket-Tester
>
> No need of new ticket.
>
>
> On Thu, Dec 5, 2013 at 6:33 PM, Paul Bors <pa...@bors.ws> wrote:
>
> > Yes, we are using the
> .FeedbackMessages#hasMessage(IFeedbackMessageFilter)
> > as we had no other choice.
> >
> > I'll file a ticket with a pull request now that I got used to GitHub :)
> >
> > ~ Thank you,
> > Paul Bors
> >
> >
> > On Thu, Dec 5, 2013 at 11:39 AM, Martin Grigorov <mgrigorov@apache.org
> > >wrote:
> >
> > > Hi,
> > >
> > > You are right.
> > > But I think we can only improve the javadoc.
> > > You will have to
> > > use
> > >
> >
> org.apache.wicket.feedback.FeedbackMessages#hasMessage(org.apache.wicket.feedback.IFeedbackMessageFilter)
> > > with a filter that makes exact match.
> > > I have the feeling that we added such filter but I can only
> > > see org.apache.wicket.feedback.ErrorLevelFeedbackMessageFilter that has
> > the
> > > same behavior as #hasMessage(int).
> > >
> > > Please file a ticket and we will add it.
> > >
> > >
> > > On Thu, Dec 5, 2013 at 5:24 PM, Paul Bors <pa...@bors.ws> wrote:
> > >
> > > > Currently (as of 6.10.0) the JavaDoc on
> > > > the FeedbackMessages#hasMessage(int) states that it returns true if
> and
> > > > only if a message with the specified level was registered.
> > > >
> > > > However it relies on FeedbackMessage#isLevel(int) which in turn
> return
> > > true
> > > > if whether the message level is greater than or equal to the given
> > level.
> > > >
> > > > Isn't that contradicting? I registered an Error message for my form
> > field
> > > > and I have a new behavior checking for Warnings that performs its
> > duties
> > > > because an Error message is at a lever greater than the Warning
> level.
> > > >
> > > > ~ Thank you,
> > > > Paul Bors
> > > >
> > >
> >
>
Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)
Posted by Martin Grigorov <mg...@apache.org>.
I've backported ExactLevelFeedbackMessageFilter from master branch.
It has been introduced for:
WICKET-4585 WicketTester.assertErrorMessages passes even if the message
isn't visible on the page
WICKET-5128 Allow for Testing Component relative Feedback-Messages in
Wicket-Tester
No need of new ticket.
On Thu, Dec 5, 2013 at 6:33 PM, Paul Bors <pa...@bors.ws> wrote:
> Yes, we are using the .FeedbackMessages#hasMessage(IFeedbackMessageFilter)
> as we had no other choice.
>
> I'll file a ticket with a pull request now that I got used to GitHub :)
>
> ~ Thank you,
> Paul Bors
>
>
> On Thu, Dec 5, 2013 at 11:39 AM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
>
> > Hi,
> >
> > You are right.
> > But I think we can only improve the javadoc.
> > You will have to
> > use
> >
> org.apache.wicket.feedback.FeedbackMessages#hasMessage(org.apache.wicket.feedback.IFeedbackMessageFilter)
> > with a filter that makes exact match.
> > I have the feeling that we added such filter but I can only
> > see org.apache.wicket.feedback.ErrorLevelFeedbackMessageFilter that has
> the
> > same behavior as #hasMessage(int).
> >
> > Please file a ticket and we will add it.
> >
> >
> > On Thu, Dec 5, 2013 at 5:24 PM, Paul Bors <pa...@bors.ws> wrote:
> >
> > > Currently (as of 6.10.0) the JavaDoc on
> > > the FeedbackMessages#hasMessage(int) states that it returns true if and
> > > only if a message with the specified level was registered.
> > >
> > > However it relies on FeedbackMessage#isLevel(int) which in turn return
> > true
> > > if whether the message level is greater than or equal to the given
> level.
> > >
> > > Isn't that contradicting? I registered an Error message for my form
> field
> > > and I have a new behavior checking for Warnings that performs its
> duties
> > > because an Error message is at a lever greater than the Warning level.
> > >
> > > ~ Thank you,
> > > Paul Bors
> > >
> >
>
Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)
Posted by Paul Bors <pa...@bors.ws>.
Yes, we are using the .FeedbackMessages#hasMessage(IFeedbackMessageFilter)
as we had no other choice.
I'll file a ticket with a pull request now that I got used to GitHub :)
~ Thank you,
Paul Bors
On Thu, Dec 5, 2013 at 11:39 AM, Martin Grigorov <mg...@apache.org>wrote:
> Hi,
>
> You are right.
> But I think we can only improve the javadoc.
> You will have to
> use
> org.apache.wicket.feedback.FeedbackMessages#hasMessage(org.apache.wicket.feedback.IFeedbackMessageFilter)
> with a filter that makes exact match.
> I have the feeling that we added such filter but I can only
> see org.apache.wicket.feedback.ErrorLevelFeedbackMessageFilter that has the
> same behavior as #hasMessage(int).
>
> Please file a ticket and we will add it.
>
>
> On Thu, Dec 5, 2013 at 5:24 PM, Paul Bors <pa...@bors.ws> wrote:
>
> > Currently (as of 6.10.0) the JavaDoc on
> > the FeedbackMessages#hasMessage(int) states that it returns true if and
> > only if a message with the specified level was registered.
> >
> > However it relies on FeedbackMessage#isLevel(int) which in turn return
> true
> > if whether the message level is greater than or equal to the given level.
> >
> > Isn't that contradicting? I registered an Error message for my form field
> > and I have a new behavior checking for Warnings that performs its duties
> > because an Error message is at a lever greater than the Warning level.
> >
> > ~ Thank you,
> > Paul Bors
> >
>
Re: Wrong JavaDoc for FeedbackMessages#hasMessage(int)
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
You are right.
But I think we can only improve the javadoc.
You will have to
use org.apache.wicket.feedback.FeedbackMessages#hasMessage(org.apache.wicket.feedback.IFeedbackMessageFilter)
with a filter that makes exact match.
I have the feeling that we added such filter but I can only
see org.apache.wicket.feedback.ErrorLevelFeedbackMessageFilter that has the
same behavior as #hasMessage(int).
Please file a ticket and we will add it.
On Thu, Dec 5, 2013 at 5:24 PM, Paul Bors <pa...@bors.ws> wrote:
> Currently (as of 6.10.0) the JavaDoc on
> the FeedbackMessages#hasMessage(int) states that it returns true if and
> only if a message with the specified level was registered.
>
> However it relies on FeedbackMessage#isLevel(int) which in turn return true
> if whether the message level is greater than or equal to the given level.
>
> Isn't that contradicting? I registered an Error message for my form field
> and I have a new behavior checking for Warnings that performs its duties
> because an Error message is at a lever greater than the Warning level.
>
> ~ Thank you,
> Paul Bors
>