You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/11/17 06:18:31 UTC
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3536: Fixes #3370 .Fix and change some code structure

coveralls edited a comment on issue #3536: Fixes #3370 .Fix and change some code structure
URL: https://github.com/apache/incubator-shardingsphere/pull/3536#issuecomment-554609011
 
 
   ## Pull Request Test Coverage Report for [Build 930](https://coveralls.io/builds/27036916)
   
   * **115** of **287**   **(40.07%)**  changed or added relevant lines in **29** files are covered.
   * **56** unchanged lines in **28** files lost coverage.
   * Overall coverage increased (+**0.09%**) to **68.593%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/MySQLDataSourceMetaData.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2Fdatasource%2Fdialect%2FMySQLDataSourceMetaData.java#L66) | 12 | 13 | 92.31%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/OracleDataSourceMetaData.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2Fdatasource%2Fdialect%2FOracleDataSourceMetaData.java#L67) | 12 | 13 | 92.31%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/PostgreSQLDataSourceMetaData.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2Fdatasource%2Fdialect%2FPostgreSQLDataSourceMetaData.java#L67) | 12 | 13 | 92.31%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/SQL92DataSourceMetaData.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2Fdatasource%2Fdialect%2FSQL92DataSourceMetaData.java#L65) | 12 | 13 | 92.31%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/SQLServerDataSourceMetaData.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2Fdatasource%2Fdialect%2FSQLServerDataSourceMetaData.java#L67) | 12 | 13 | 92.31%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/H2DatabaseType.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspi%2Fdatabase%2FH2DatabaseType.java#L45) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/MariaDBDatabaseType.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspi%2Fdatabase%2FMariaDBDatabaseType.java#L45) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/OracleDatabaseType.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspi%2Fdatabase%2FOracleDatabaseType.java#L44) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/PostgreSQLDatabaseType.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspi%2Fdatabase%2FPostgreSQLDatabaseType.java#L44) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/SQL92DatabaseType.java](https://coveralls.io/builds/27036916/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspi%2Fdatabase%2FSQL92DatabaseType.java#L44) | 0 | 1 | 0.0%
   <!-- | **Total:** | **115** | **287** | **40.07%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/constant/PostgreSQLColumnType.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fconstant%2FPostgreSQLColumnType.java#L158) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/admin/PostgreSQLUnsupportedCommandPacket.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fadmin%2FPostgreSQLUnsupportedCommandPacket.java#L33) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/PostgreSQLCommandPacketFactory.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2FPostgreSQLCommandPacketFactory.java#L39) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/PostgreSQLCommandPacket.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2FPostgreSQLCommandPacket.java#L28) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/PostgreSQLCommandPacketTypeLoader.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2FPostgreSQLCommandPacketTypeLoader.java#L29) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/PostgreSQLBinaryResultSetRowPacket.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2FPostgreSQLBinaryResultSetRowPacket.java#L42) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLBinaryProtocolValueFactory.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLBinaryProtocolValueFactory.java#L33) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLDateBinaryProtocolValue.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLDateBinaryProtocolValue.java#L30) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLDoubleBinaryProtocolValue.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLDoubleBinaryProtocolValue.java#L27) | 1 | 0.0% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLFloatBinaryProtocolValue.java](https://coveralls.io/builds/27036916/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLFloatBinaryProtocolValue.java#L27) | 1 | 0.0% |
   <!-- | **Total:** | **56** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/27036916/badge)](https://coveralls.io/builds/27036916) |
   | :-- | --: |
   | Change from base [Build 555](https://coveralls.io/builds/27009471): |  0.09% |
   | Covered Lines: | 11632 |
   | Relevant Lines: | 16958 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services