You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/29 10:06:17 UTC
[GitHub] [airflow] ashb opened a new pull request #11934: Add missing space to log message in task completion logs
ashb opened a new pull request #11934:
URL: https://github.com/apache/airflow/pull/11934
Previously it looked like this
INFO - Marking task as SUCCESS.dag_id=scenario1_case1_1_1, ...
Now it looks like
INFO - Marking task as SUCCESS. dag_id=scenario1_case1_1_1, ...
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #11934: Add missing space to log message in task completion logs
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #11934:
URL: https://github.com/apache/airflow/pull/11934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11934: Add missing space to log message in task completion logs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11934:
URL: https://github.com/apache/airflow/pull/11934#issuecomment-718588013
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11934: Add missing space to log message in task completion logs
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11934:
URL: https://github.com/apache/airflow/pull/11934#discussion_r514297119
##########
File path: airflow/models/taskinstance.py
##########
@@ -1087,7 +1087,7 @@ def _run_raw_task(
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
self.log.info(
- 'Marking task as SKIPPED.'
+ 'Marking task as SKIPPED. '
'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
Review comment:
```suggestion
'(dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s)',
```
Just an idea to make it more "structure" but definitely not a blocker
##########
File path: airflow/models/taskinstance.py
##########
@@ -1087,7 +1087,7 @@ def _run_raw_task(
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
self.log.info(
- 'Marking task as SKIPPED.'
+ 'Marking task as SKIPPED. '
'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
Review comment:
```suggestion
'(dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s)',
```
Just an idea to make it more "structured" but definitely not a blocker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org