You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Sylwester Lachiewicz (JIRA)" <ji...@apache.org> on 2019/01/20 15:06:00 UTC

[jira] [Commented] (MPH-95) Make "plugin" field protected so DescribeMojo can be extended

    [ https://issues.apache.org/jira/browse/MPH-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747481#comment-16747481 ] 

Sylwester Lachiewicz commented on MPH-95:
-----------------------------------------

From maven-plugin-plugin:3.3 output generated from mvn help:describe -Dplugin=javadoc -Dgoal=help -Ddetail and mvn javadoc:help -Dgoal=help -Ddetail are equal.

Subclassing DescribeMojo would add a dependency to maven-help-plugin dependencies to every plugin what we want to avoid.

> Make "plugin" field protected so DescribeMojo can be extended
> -------------------------------------------------------------
>
>                 Key: MPH-95
>                 URL: https://issues.apache.org/jira/browse/MPH-95
>             Project: Maven Help Plugin
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Major
>
> The standalone Help Mojo has been updated to handle annotations, but the generated help mojos added to mojos have not.
> Rather than copy the code to every new Mojo, the generated HelpMojo could be simplified by subclassing DescribeMojo and passing in the plugin Id.
> However, the "plugin" field is private. Making it protected (or providing a protected setter) would allow subclasses to set the field without needing to use reflection.
> A further enhancement might be to support a method whereby the calling plugin can provide a link to its plugin.xml or other config item that provides the necessary information, thus reducing the code needed in the calling plugin



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)