You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/29 02:37:47 UTC
[GitHub] [ozone] neils-dev opened a new pull request #2088: HDDS-3752. Patch for o3fs issue with not listing bucket contents WITHOUT trailin…
neils-dev opened a new pull request #2088:
URL: https://github.com/apache/ozone/pull/2088
...Originally when _**ls -R** o3fs://bucket.vol_ issued, resulted in _No such file/directory_ error. Fixed path so that contents of bucket listed when command issued without trailing slash. Patch affects one file, the _BasicOzoneFileSystem_ filesystem abstraction. Patch overrides the _fixRelativePart_ method to allow Path to be resolved correctly for _OzoneFileSystem_ implementation.
## What changes were proposed in this pull request?
Patch fixed issue with _OzoneFileSystem_ implementation of _FileSystem_ for _**o3fs**_ space when _-ls_ command request without trailing slash of 2nd level bucket (vol/bucket). Problem is that request interpreted as a 'relative' address resolving to the 'working directory' which is evaluated to an error '_Directory or File Not Found_'.
Patch to _BasicOzoneFileSystem_ overrides the _fixRelativePart_ method to resolve the Path to the correct Path (adding a trailing slash). _BasicOzoneFileSystem_ implementation of _FileSystem_ then correctly evaluates the path.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3752
## How was this patch tested?
Passed unit and integration tests.
Manual testing:
Tested though ozone fs cli commands (see attached images).
Pre-patch:
**Fix with patch**:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on pull request #2088: HDDS-3752. Patch for o3fs issue with not listing bucket contents WITHOUT trailin…
Posted by GitBox <gi...@apache.org>.
neils-dev commented on pull request #2088:
URL: https://github.com/apache/ozone/pull/2088#issuecomment-809737855
Thanks **@avijayanhwx** . Pushed changes to pass coding style checks. Simplification of _fixRelativePart_ method (calling super for non implementation specific operations for method).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2088: HDDS-3752. Patch for o3fs issue with not listing bucket contents WITHOUT trailin…
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2088:
URL: https://github.com/apache/ozone/pull/2088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org