[jira] Commented: (JAMES-372) Inboxes deleted during OutOfMemoryError

["Stefano Bagnara (JIRA)" <se...@james.apache.org>]

    [ http://issues.apache.org/jira/browse/JAMES-372?page=comments#action_12314217 ] 

Stefano Bagnara commented on JAMES-372:
---------------------------------------

OutOfMemoryError is not a RuntimeException but an Error, isn't it?

The debug was from that code but I think the exception was really a RuntimeException and not an OutOfMemoryError: it probably was encapsulated in a RuntimeException before.

Let's read the DEBUG log...

> DEBUG mailstore: Exception retrieving mail:
> java.lang.RuntimeException: Exception caught while retrieving an 
> object, cause: java.lang.OutOfMemoryError, so we're deleting it... 
> good riddance!

So the "re" caught is a Runtime and is created by the File_Persistent_Object_Repository with this snippet:

catch( final Throwable e )
{
    throw new RuntimeException(
    "Exception caught while retrieving an object, cause: " + e.toString() );
} 

I think this patch is wrong (the OOME is not a RuntimeException!). You should change the File_Persistent_Object_Repository.


> Inboxes deleted during OutOfMemoryError
> ---------------------------------------
>
>          Key: JAMES-372
>          URL: http://issues.apache.org/jira/browse/JAMES-372
>      Project: James
>         Type: Bug
>   Components: MailStore & MailRepository
>     Versions: 2.2.0
>  Environment: Linux
>     Reporter: Theodore Watson
>      Fix For: 3.0
>  Attachments: AvalonMailRepository.java, AvalonMailRepository.java.diff
>
> I received several hundred of the following messages in my mailstore log and lost entire inboxes at the same time:
> 04/05/05 11:08:30 DEBUG mailstore: Exception retrieving mail:
> java.lang.RuntimeException: Exception caught while retrieving an
> object, cause: java.lang.OutOfMemoryError, so we're deleting it... good
> riddance!
> I'm guessing whoever was checking their email at this time lost all their mail.
> I was also asked to remind you to change your error message.  I must say, I laughed after reading "good riddance" in regard to all of these valid emails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org