You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "grantmcdermott (via GitHub)" <gi...@apache.org> on 2024/09/09 23:47:38 UTC
[PR] MINOR: [R] Add r-universe instructions [arrow]
grantmcdermott opened a new pull request, #44033:
URL: https://github.com/apache/arrow/pull/44033
Closes #44032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39638: [Docs][R] Add r-universe instructions [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #44033:
URL: https://github.com/apache/arrow/pull/44033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39638: [Docs][R] Add r-universe instructions [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2344223585
Good call @eitsupi, I've changed the title and updated the related issue too. These changes now look good to me @grantmcdermott, thanks. And to your point about potential further improvements, those are probably best as separate issue.
@thisisnic do you want one more look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39638: [Docs][R] Add r-universe instructions [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2344212282
:warning: GitHub issue #39638 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2339789451
Thanks for making this PR @grantmcdermott! Just to confirm, we do use it for release builds and not dev builds. This addition is still welcome though, just with that bit updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "grantmcdermott (via GitHub)" <gi...@apache.org>.
grantmcdermott commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1751212837
##########
r/README.md:
##########
@@ -23,7 +24,17 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe.
+
+```r
+# Binaries for MacOS/Windows
+install.packages("arrow", repos = "https://apache.r-universe.dev")
+
+# Binaries for Linux (Ubuntu 24.04)
+install.packages("arrow", repos = "https://rpolars.r-universe.dev/bin/linux/noble/4.4")
Review Comment:
> Probably a copying error.
Ah, good catch.
> As it is, I would not recommend using the binary URL for Ubuntu in R-universe unless you are familiar with the internals of R-universe.
Fair enough. I'll remove and link to the [description](https://docs.r-universe.dev/install/binaries.html) of Ubuntu binaries in the r-universe docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1752927931
##########
r/README.md:
##########
@@ -23,7 +24,15 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe, which provides pre-compiled binaries for the most commonly used operating systems.[^1]
Review Comment:
Ah, you're right. I see three commonly-used variants but Jeroen seems to prefer `R-universe` which is pretty much as official as it gets. I'll edit my suggestions.
##########
r/README.md:
##########
@@ -23,7 +24,15 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe, which provides pre-compiled binaries for the most commonly used operating systems.[^1]
Review Comment:
```suggestion
Alternatively, you can install the development version of arrow from [R-universe](https://r-universe.dev/), which provides pre-compiled binaries for the most commonly used operating systems.[^1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1751343677
##########
r/README.md:
##########
@@ -3,6 +3,7 @@
<!-- badges: start -->
[](https://cran.r-project.org/package=arrow)
+<a href="https://apache.r-universe.dev"><img src="https://apache.r-universe.dev/badges/arrow" class="img-fluid" alt="R-universe status badge"></a>
Review Comment:
Just to check, is there a reason that this needs to be raw html unlike the other badges?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "grantmcdermott (via GitHub)" <gi...@apache.org>.
grantmcdermott commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1752906103
##########
r/README.md:
##########
@@ -23,7 +24,15 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe, which provides pre-compiled binaries for the most commonly used operating systems.[^1]
+
+[^1]: Linux users should consult the R-universe [documentation](https://docs.r-universe.dev/install/binaries.html) for the exact repo URL path and limitations.
Review Comment:
Same note about lowercase styling as per above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "grantmcdermott (via GitHub)" <gi...@apache.org>.
grantmcdermott commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1752914170
##########
r/README.md:
##########
@@ -3,6 +3,7 @@
<!-- badges: start -->
[](https://cran.r-project.org/package=arrow)
+<a href="https://apache.r-universe.dev"><img src="https://apache.r-universe.dev/badges/arrow" class="img-fluid" alt="R-universe status badge"></a>
Review Comment:
No reason. I'll switch to markdown and also bump to the right of the R-CMD check badge, so that it is in the same position as the conda forge badge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2343609165
Maybe the PR title is needed updated to something like `GH-39638: [Docs][R] ...`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "grantmcdermott (via GitHub)" <gi...@apache.org>.
grantmcdermott commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2339566812
> The apache R-universe is managed here, but it seems unclear at this time whether it is for release builds or edge builds. https://github.com/r-universe-org/apache.r-universe.dev
>
> If it is for edge builds, R-multiverse may be more suitable for installing release builds. Or it may be worth updating the apache universe to show the same version as the CRAN release.
Hmmm. Fair point. Let's wait for the arrow devs to weigh in. It may be easiest to keep the current managed repo and just remove the "development" language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "grantmcdermott (via GitHub)" <gi...@apache.org>.
grantmcdermott commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2342356033
Thanks for the feedback all. I've actioned the requested changes (modulo the uppercase suggestion). Let me know if you want changes to the wording.
Some other points/thoughts:
- I didn't mention anything about R-universe potentially guaranteeing a richer feature set because of CRAN restrictions (e.g., like we've experienced on MacOS with certain releases in the past w.r.t. S3 access etc.) I feel that this is a potentially important point that users should know about. But you all have better visibility to this stuff on the dev side.
- Looking over the README, I feel like there's quite a bit of unnecessary repetition, made worse by inconsistent referencing the the upstream C++ docs and the R package website. For example...
> To learn more about the Apache Arrow project, see the parent documentation of the [Arrow Project](https://arrow.apache.org/). The Arrow project provides functionality for a wide range of data analysis tasks to store, process and move data fast. See the [read/write article](https://arrow.apache.org/docs/r/articles/read_write.html) to learn about reading and writing data files, [data wrangling](https://arrow.apache.org/docs/r/articles/data_wrangling.html) to learn how to use dplyr syntax with arrow objects, and the [function documentation](https://arrow.apache.org/docs/r/reference/acero.html) for a full list of supported functions within dplyr queries.
(note the mixed links the upstream docs and the individual R vignettes) ... is followed by a dedicated `"What can the arrow package do?"` do only a few paragraphs later. Better IMO to consolidate this information in one place and generally prioritize the R package documentation/website above the upstream docs. I'm happy to take a crack at consolidation as part of this PR, but I imagine that you would prefer a separate PR. LMK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1752164124
##########
r/README.md:
##########
@@ -23,7 +24,15 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe, which provides pre-compiled binaries for the most commonly used operating systems.[^1]
Review Comment:
```suggestion
Alternatively, you can install the development version of arrow from [R-Universe](https://r-universe.dev/), which provides pre-compiled binaries for the most commonly used operating systems.[^1]
```
##########
r/README.md:
##########
@@ -23,7 +24,15 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe, which provides pre-compiled binaries for the most commonly used operating systems.[^1]
+
+[^1]: Linux users should consult the R-universe [documentation](https://docs.r-universe.dev/install/binaries.html) for the exact repo URL path and limitations.
Review Comment:
```suggestion
[^1]: Linux users should consult the R-Universe [documentation](https://docs.r-universe.dev/install/binaries.html) for the exact repo URL path and limitations.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39638: [Docs][R] Add r-universe instructions [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44033:
URL: https://github.com/apache/arrow/pull/44033#issuecomment-2351331375
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3eb41355d1cf7b4f50af04f901924f417d6da91a.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/30156827779) has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1751174905
##########
r/README.md:
##########
@@ -23,7 +24,17 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe.
+
+```r
+# Binaries for MacOS/Windows
+install.packages("arrow", repos = "https://apache.r-universe.dev")
Review Comment:
This command should fail because the repository (`https://apache.r-universe.dev`) does not contain any dependencies for the arrow package.
```suggestion
install.packages('arrow', repos = c('https://apache.r-universe.dev', 'https://cloud.r-project.org'))
```
##########
r/README.md:
##########
@@ -23,7 +24,17 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe.
+
+```r
+# Binaries for MacOS/Windows
+install.packages("arrow", repos = "https://apache.r-universe.dev")
+
+# Binaries for Linux (Ubuntu 24.04)
+install.packages("arrow", repos = "https://rpolars.r-universe.dev/bin/linux/noble/4.4")
Review Comment:
Probably a copying error.
As it is, I would not recommend using the binary URL for Ubuntu in R-universe unless you are familiar with the internals of R-universe.
The installation will fail unless you understand what the differences in Ubuntu versions mean.
e.g. etiennebacher/tidypolars#137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Add r-universe instructions [arrow]
Posted by "grantmcdermott (via GitHub)" <gi...@apache.org>.
grantmcdermott commented on code in PR #44033:
URL: https://github.com/apache/arrow/pull/44033#discussion_r1752905718
##########
r/README.md:
##########
@@ -23,7 +24,15 @@ Windows or macOS.
install.packages("arrow")
```
-Alternatively, if you are using conda you can install arrow from conda-forge:
+Alternatively, you can install the development version of arrow from R-universe, which provides pre-compiled binaries for the most commonly used operating systems.[^1]
Review Comment:
I'm happy to add the hyperlink. But note that the official styling is with a lowercase "**u**niverse". See, for example: https://ropensci.org/r-universe/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org