You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Chi Vinh Le (JIRA)" <ji...@apache.org> on 2014/12/01 21:33:12 UTC

[jira] [Created] (THRIFT-2868) Enhance error handling in the Go client

Chi Vinh Le created THRIFT-2868:
-----------------------------------

             Summary: Enhance error handling in the Go client 
                 Key: THRIFT-2868
                 URL: https://issues.apache.org/jira/browse/THRIFT-2868
             Project: Thrift
          Issue Type: Bug
          Components: Go - Compiler, Go - Library
    Affects Versions: 0.9.2
            Reporter: Chi Vinh Le
             Fix For: 0.9.3


The Go client doesn't do proper error checking. E.g. it doesn't check whether the received method name is correct nor if the message type has the expected value.

The following PR enhances the Go client error handling by the following:
 - Check if method name is correct -> if not return thrift.WRONG_METHOD_NAME  
 - Check if MessageType is thrift.REPLY or EXCEPTION -> if not return thrift.INVALID_MESSAGE_TYPE_EXCEPTION
 - Checking the sequence id is done before checking the message type

Includes test cases for every error case.

https://github.com/apache/thrift/pull/297



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)