You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2013/06/10 10:35:26 UTC
Re: svn commit: r1490326 -
/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
breser@apache.org wrote on Thu, Jun 06, 2013 at 15:36:09 -0000:
> Author: breser
> Date: Thu Jun 6 15:36:08 2013
> New Revision: 1490326
>
> URL: http://svn.apache.org/r1490326
> Log:
> svnpubsub: Remove version header that was uninitentionally added in r1490045.
>
> [in tools/server-side/svnpubsub]
> * svnpubsub/server.py
> (Client.write_start): Remove version header.
>
>
> Modified:
> subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
>
> Modified: subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py?rev=1490326&r1=1490325&r2=1490326&view=diff
> ==============================================================================
> --- subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py (original)
> +++ subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py Thu Jun 6 15:36:08 2013
> @@ -184,7 +184,6 @@ class Client(object):
>
> def write_start(self):
> self.r.setHeader('content-type', 'application/vnd.apache.vc-notify+json')
> - self.r.setHeader('X-SVNPubSub-Version', '1')
Perhaps leave it in? It's little overhead to maintain and might make
somebody's life easier.
> self.write('{"svnpubsub": {"version": 1}}\n\0')
>
> def write_heartbeat(self):
>
>
Re: svn commit: r1490326 -
/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Ben Reser wrote on Tue, Jun 11, 2013 at 09:53:59 +0100:
> On Mon, Jun 10, 2013 at 9:35 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > Perhaps leave it in? It's little overhead to maintain and might make
> > somebody's life easier.
>
> If you want to put it in that's fine. But at this point I don't think
> it'll be in 1.8.0 since I merged the change removing it.
+1 to merge a change re-adding that header to 1.8.1 :-)
Re: svn commit: r1490326 - /subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
Posted by Ben Reser <be...@reser.org>.
On Mon, Jun 10, 2013 at 9:35 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Perhaps leave it in? It's little overhead to maintain and might make
> somebody's life easier.
If you want to put it in that's fine. But at this point I don't think
it'll be in 1.8.0 since I merged the change removing it.
Re: svn commit: r1490326 - /subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
Posted by Ben Reser <be...@reser.org>.
On Mon, Jun 10, 2013 at 9:35 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Perhaps leave it in? It's little overhead to maintain and might make
> somebody's life easier.
If you want to put it in that's fine. But at this point I don't think
it'll be in 1.8.0 since I merged the change removing it.