You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/31 06:49:09 UTC
[GitHub] sijie commented on a change in pull request #3268: Optimization of
binlog to pulsar use canal
sijie commented on a change in pull request #3268: Optimization of binlog to pulsar use canal
URL: https://github.com/apache/pulsar/pull/3268#discussion_r244557571
##########
File path: pulsar-io/canal/src/main/java/org/apache/pulsar/io/canal/CanalAbstractSource.java
##########
@@ -131,10 +124,11 @@ protected void process() {
connector.subscribe();
while (running) {
Message message = connector.getWithoutAck(canalSourceConfig.getBatchSize());
- // delete the setRaw in new version of canal-client
message.setRaw(false);
- List<FlatMessage> flatMessages = FlatMessage.messageConverter(message);
- long batchId = message.getId();
+ SimpleCanalConnector con = (SimpleCanalConnector) connector;
+ con.isLazyParseEntry();
Review comment:
I am not very familiar with Canal. does `isLazyParseEntry()` changing the state of the connector, so the `con` will parse entries lazily?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services