[GitHub] [airflow] potiuk edited a comment on pull request #13660: Add quick start for Airflow on Docker

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #13660:
URL: https://github.com/apache/airflow/pull/13660#issuecomment-766320076


   Looks good but I added a few fixups: 
   
   1) Missing .dockerignore entries for logs/plugins/env/dags
   2)  The DOCKER_COMPOSE_ARGS are not needed IMHO . Docker compose run will allocate terminal as needed and you can disable it with -T flag. Also interactive mode works out-of-the-box with docker-compose-run
   3) I removed 'airflow' from docker-compose run in airflow.sh. It is not neeed, it does not work with airfllow 2.0 image and it does not allow to run the two useful `python` and `bash` commands
   4) changed ${*} into "${@}" (that's the proper way of passing parameters containing spaces potentially) 
   5) I added examples with "python/bash" commands.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org