[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3375: [CALCITE-5583] JDBC adapter does not generate 'SELECT *' when duplicate field names are possible

["JiajunBernoulli (via GitHub)" <gi...@apache.org>]

JiajunBernoulli commented on code in PR #3375:
URL: https://github.com/apache/calcite/pull/3375#discussion_r1299159607


##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -261,9 +263,24 @@ protected SqlCall as(SqlNode e, String alias, String... fieldNames) {
 
   /** Returns whether a list of expressions projects all fields, in order,
    * from the input, with the same names. */
-  public static boolean isStar(List<RexNode> exps, RelDataType inputRowType,
+  public static boolean isStar(List<RexNode> exps, RelNode input,

Review Comment:
   This is a public static method, it is best not to modify its parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org