You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/29 09:27:59 UTC

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6541: Added -fPIC option when building jlink-nuttx.so.

fjpanag commented on code in PR #6541:
URL: https://github.com/apache/incubator-nuttx/pull/6541#discussion_r909409655


##########
tools/Makefile.host:
##########
@@ -228,7 +228,7 @@ endif
 # jlink-nuttx - Create jlink GDBServer nuttx plugin
 
 jlink-nuttx$(HOSTDYNEXT): jlink-nuttx.c
-	$(Q) $(HOSTCC) $(HOSTCFLAGS) -shared jlink-nuttx.c -o jlink-nuttx$(HOSTDYNEXT)
+	$(Q) $(HOSTCC) $(HOSTCFLAGS) -shared -fPIC jlink-nuttx.c -o jlink-nuttx$(HOSTDYNEXT)

Review Comment:
   Are you sure about this? Everything else builds fine. Also `HOSTCFLAGS` is used for executables too, not only libraries.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org