You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/01/27 19:25:55 UTC
Review Request 56033: Remove white border from the content area in
popup wizards
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56033/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
Bugs: AMBARI-19754
https://issues.apache.org/jira/browse/AMBARI-19754
Repository: ambari
Description
-------
The idea is to get rid of the white border around the content so that it looks more polished.
Diffs
-----
ambari-web/app/styles/modal_popups.less c10ef30
ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f
ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js c4a428e
Diff: https://reviews.apache.org/r/56033/diff/
Testing
-------
20325 passing (26s)
153 pending
Thanks,
Xi Wang
Re: Review Request 56033: Remove white border from the content area
in popup wizards
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56033/#review163321
-----------------------------------------------------------
Ship it!
Ship It!
- Vivek Ratnavel Subramanian
On Jan. 27, 2017, 7:25 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56033/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:25 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19754
> https://issues.apache.org/jira/browse/AMBARI-19754
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The idea is to get rid of the white border around the content so that it looks more polished.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/modal_popups.less c10ef30
> ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js c4a428e
>
> Diff: https://reviews.apache.org/r/56033/diff/
>
>
> Testing
> -------
>
> 20325 passing (26s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 56033: Remove white border from the content area
in popup wizards
Posted by Xi Wang <xw...@hortonworks.com>.
> On Jan. 27, 2017, 12:11 p.m., Jaimin Jetly wrote:
> > Does this cover modal popups for all wizards ?
> > Has this patch been tested with wizards ?
Yes, covered all wizards in the popup. Tested and you can see scrennshots in the JIRA.
- Xi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56033/#review163323
-----------------------------------------------------------
On Jan. 27, 2017, 11:25 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56033/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19754
> https://issues.apache.org/jira/browse/AMBARI-19754
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The idea is to get rid of the white border around the content so that it looks more polished.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/modal_popups.less c10ef30
> ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js c4a428e
>
> Diff: https://reviews.apache.org/r/56033/diff/
>
>
> Testing
> -------
>
> 20325 passing (26s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 56033: Remove white border from the content area
in popup wizards
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56033/#review163323
-----------------------------------------------------------
Does this cover modal popups for all wizards ?
Has this patch been tested with wizards ?
- Jaimin Jetly
On Jan. 27, 2017, 7:25 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56033/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:25 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19754
> https://issues.apache.org/jira/browse/AMBARI-19754
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The idea is to get rid of the white border around the content so that it looks more polished.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/modal_popups.less c10ef30
> ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js c4a428e
>
> Diff: https://reviews.apache.org/r/56033/diff/
>
>
> Testing
> -------
>
> 20325 passing (26s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 56033: Remove white border from the content area
in popup wizards
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56033/#review163360
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Jan. 27, 2017, 7:25 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56033/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 7:25 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-19754
> https://issues.apache.org/jira/browse/AMBARI-19754
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The idea is to get rid of the white border around the content so that it looks more polished.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/modal_popups.less c10ef30
> ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js c4a428e
>
> Diff: https://reviews.apache.org/r/56033/diff/
>
>
> Testing
> -------
>
> 20325 passing (26s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>