You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/01/19 19:56:56 UTC

[GitHub] [guacamole-server] stefan-esq commented on a change in pull request #327: GUACAMOLE-1267: Add VNC setting 'disable-remote-input'

stefan-esq commented on a change in pull request #327:
URL: https://github.com/apache/guacamole-server/pull/327#discussion_r560446127



##########
File path: src/protocols/vnc/vnc.c
##########
@@ -385,6 +385,17 @@ void* guac_vnc_client_thread(void* data) {
     }
 #endif
 
+    /* Disable remote console */
+    if (settings->disable_remote_input) {
+        rfbSetServerInputMsg no_remote_console = {
+                .type = rfbSetServerInput, .status = 1, .pad = 0
+        };
+        rfbBool success = WriteToRFBServer(rfb_client,
+                                           (char *) &no_remote_console, sz_rfbSetServerInputMsg);

Review comment:
       I have no clue, this is based on custom code written by another developer inside our company, I have rewritten most of it so it is configurable and does not always disable the input. As requested I have changed this to PermitServerInput.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org