You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/10 00:21:33 UTC
[GitHub] [incubator-nuttx] YuuichiNakamura commented on a change in pull request #1377: Add task trace support
YuuichiNakamura commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r452558506
##########
File path: arch/arm/src/common/arm_initialize.c
##########
@@ -159,8 +159,7 @@ void up_initialize(void)
loop_register(); /* Standard /dev/loop */
#endif
-#if defined(CONFIG_SCHED_INSTRUMENTATION_BUFFER) && \
Review comment:
I got it.
##########
File path: drivers/syslog/Kconfig
##########
@@ -64,7 +64,7 @@ endif
config DRIVER_NOTE
bool "Scheduler instrumentation driver"
default n
- depends on SCHED_INSTRUMENTATION_BUFFER && SCHED_NOTE_GET
+ depends on (SCHED_INSTRUMENTATION_BUFFER && SCHED_NOTE_GET) || SCHED_INSTRUMENTATION_FILTER
Review comment:
No. SCHED_INSTRUMENTATION decides only whether note hooks are inserted in the kernel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org