You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jordi Deu-Pons (JIRA)" <ji...@apache.org> on 2012/04/26 10:10:13 UTC
[jira] [Created] (WICKET-4517) Wicket-core don't export "internal"
packages in OSGi manifest.
Jordi Deu-Pons created WICKET-4517:
--------------------------------------
Summary: Wicket-core don't export "internal" packages in OSGi manifest.
Key: WICKET-4517
URL: https://issues.apache.org/jira/browse/WICKET-4517
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.0.0-beta1
Reporter: Jordi Deu-Pons
Priority: Minor
The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
@@ -746,6 +746,7 @@
</goals>
<configuration>
<instructions>
+ <Export-Package>org.apache.wicket*</Export-Package>
<Import-Package>org.apache.wicket*</Import-Package>
<DynamicImport-Package>*</DynamicImport-Package>
<_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4517) Wicket-core don't export
"internal" packages in OSGi manifest.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271181#comment-13271181 ]
Martin Grigorov commented on WICKET-4517:
-----------------------------------------
Maybe it is better to improve wicket-extensions to not depend on *internal* code from wicket-core.
I'll apply Andreas' suggestion: <Export-Package>*</Export-Package>.
Let us know whether this improves the situation because we are going to release -beta2 very soon.
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
> Key: WICKET-4517
> URL: https://issues.apache.org/jira/browse/WICKET-4517
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Jordi Deu-Pons
> Priority: Minor
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
> </goals>
> <configuration>
> <instructions>
> + <Export-Package>org.apache.wicket*</Export-Package>
> <Import-Package>org.apache.wicket*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4517) Wicket-core don't export "internal"
packages in OSGi manifest.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4517:
------------------------------------
Issue Type: Sub-task (was: Bug)
Parent: WICKET-4438
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
> Key: WICKET-4517
> URL: https://issues.apache.org/jira/browse/WICKET-4517
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Jordi Deu-Pons
> Priority: Minor
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
> </goals>
> <configuration>
> <instructions>
> + <Export-Package>org.apache.wicket*</Export-Package>
> <Import-Package>org.apache.wicket*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4517) Wicket-core don't export "internal"
packages in OSGi manifest.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4517.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0-RC1
Assignee: Martin Grigorov
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
> Key: WICKET-4517
> URL: https://issues.apache.org/jira/browse/WICKET-4517
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Jordi Deu-Pons
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0-RC1
>
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
> </goals>
> <configuration>
> <instructions>
> + <Export-Package>org.apache.wicket*</Export-Package>
> <Import-Package>org.apache.wicket*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4517) Wicket-core don't export
"internal" packages in OSGi manifest.
Posted by "Jordi Deu-Pons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270611#comment-13270611 ]
Jordi Deu-Pons commented on WICKET-4517:
----------------------------------------
I've been using beta1 with this change in an OSGi container without any problem.
I opened a pull request on https://github.com/apache/wicket/pull/5.
Without this change it's impossible to deploy wicket-extensions in an OSGi container, because it depends on a package that it's not exported in the core.
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
> Key: WICKET-4517
> URL: https://issues.apache.org/jira/browse/WICKET-4517
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Jordi Deu-Pons
> Priority: Minor
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
> </goals>
> <configuration>
> <instructions>
> + <Export-Package>org.apache.wicket*</Export-Package>
> <Import-Package>org.apache.wicket*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4517) Wicket-core don't export
"internal" packages in OSGi manifest.
Posted by "Jordi Deu-Pons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271219#comment-13271219 ]
Jordi Deu-Pons commented on WICKET-4517:
----------------------------------------
Ok, perfect. Now I've been able to deploy wicket-extensions without any problem.
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
> Key: WICKET-4517
> URL: https://issues.apache.org/jira/browse/WICKET-4517
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Jordi Deu-Pons
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0-RC1
>
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
> </goals>
> <configuration>
> <instructions>
> + <Export-Package>org.apache.wicket*</Export-Package>
> <Import-Package>org.apache.wicket*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4517) Wicket-core don't export
"internal" packages in OSGi manifest.
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262481#comment-13262481 ]
Andreas Pieber commented on WICKET-4517:
----------------------------------------
Well, overwriting the Export-Package defaults by adding <Export-Package>org.apache.wicket*</Export-Package> isn't basically a bad idea. Nevertheless, it will still avoid the export of the wicket.property files which are in the root directory of the bundles. This will therefore affect (as it definitely does before) affect the loading of the initializers.
I would suggest to overwrite the export for now by adding <Export-Package>*</Export-Package> and doing a more detailed per-bundle analyse once we add more osgi support (and finally remove this hated DynamicImport-Package tag).
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
> Key: WICKET-4517
> URL: https://issues.apache.org/jira/browse/WICKET-4517
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Jordi Deu-Pons
> Priority: Minor
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
> </goals>
> <configuration>
> <instructions>
> + <Export-Package>org.apache.wicket*</Export-Package>
> <Import-Package>org.apache.wicket*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <_nouses>true</_nouses>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira