You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2022/12/19 19:09:53 UTC
[GitHub] [shiro] lprimak opened a new pull request, #574: added jdk11+ profile and apropriate failsafe and surefire options
lprimak opened a new pull request, #574:
URL: https://github.com/apache/shiro/pull/574
<!--
For Security Vulnerabilities, please email: security@shiro.apache.org
For more details on how to report a vulnerablity see: https://www.apache.org/security/
-->
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SHIRO) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SHIRO-XXX] - Fixes bug in SessionManager`,
where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1057696598
##########
pom.xml:
##########
@@ -71,12 +71,14 @@
<buildNumber>${user.name}-${maven.build.timestamp}</buildNumber>
<project.build.outputTimestamp>2022-03-22T23:08:15Z</project.build.outputTimestamp>
<jacoco.skip>true</jacoco.skip>
+ <surefire.version>3.0.0-M7</surefire.version>
<!--suppress CheckTagEmptyBody -->
<surefire.argLine></surefire.argLine>
<!--suppress CheckTagEmptyBody -->
<failsafe.argLine></failsafe.argLine>
<nexus.deploy.skip>false</nexus.deploy.skip>
-
+ <jacocoPort>52212</jacocoPort>
Review Comment:
Usually, it is not needed to specify a port. Even with integration tests. At least when using meecrowave, as it sits in the same JVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1055602603
##########
pom.xml:
##########
@@ -1575,6 +1589,16 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
+ <surefire.argLine>-Xshare:off ${failsafe.argLine}</surefire.argLine>
Review Comment:
If causes warnings. It also passes the J9 tests but I’ll double check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak merged pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak merged PR #574:
URL: https://github.com/apache/shiro/pull/574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1064028992
##########
pom.xml:
##########
@@ -1575,6 +1599,15 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <surefire.argLine>-XX:+IgnoreUnrecognizedVMOptions -Xshare:off</surefire.argLine>
+ </properties>
+ </profile>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] (wip) Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1056757965
##########
pom.xml:
##########
@@ -577,6 +588,9 @@
<excludes>
<exclude>**/main/**/samples/**</exclude>
</excludes>
+ <address>localhost</address>
+ <port>${jacocoPort}</port>
+ <propertyName>jacocoAgent</propertyName>
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1064029377
##########
pom.xml:
##########
@@ -1462,6 +1485,7 @@
<exclude>**/spring.factories</exclude>
<exclude>**/spring.provides</exclude>
<exclude>**/*.iml</exclude>
+ <exclude>**/target/**</exclude>
Review Comment:
.gitignore wasn't working for target, because the rat plugin doesn't ignore what's underneath the directories and git does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1057884925
##########
pom.xml:
##########
@@ -71,12 +71,14 @@
<buildNumber>${user.name}-${maven.build.timestamp}</buildNumber>
<project.build.outputTimestamp>2022-03-22T23:08:15Z</project.build.outputTimestamp>
<jacoco.skip>true</jacoco.skip>
+ <surefire.version>3.0.0-M7</surefire.version>
<!--suppress CheckTagEmptyBody -->
<surefire.argLine></surefire.argLine>
<!--suppress CheckTagEmptyBody -->
<failsafe.argLine></failsafe.argLine>
<nexus.deploy.skip>false</nexus.deploy.skip>
-
+ <jacocoPort>52212</jacocoPort>
Review Comment:
Actually, this is no longer necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1055727460
##########
pom.xml:
##########
@@ -577,6 +588,9 @@
<excludes>
<exclude>**/main/**/samples/**</exclude>
</excludes>
+ <address>localhost</address>
+ <port>${jacocoPort}</port>
+ <propertyName>jacocoAgent</propertyName>
Review Comment:
Currently, ITs do not participate in jacoco coverage. This is the infra to enable this (usage coming in the Jakarta EE PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1055571725
##########
pom.xml:
##########
@@ -543,6 +548,12 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
+ <configuration>
+ <compilerArgs>
+ <arg>-Xlint:deprecation</arg>
+ <arg>-Xlint:unchecked</arg>
+ </compilerArgs>
+ </configuration>
Review Comment:
what about maven.compiler.showWarnings (property) or showWarnings (configuration item)? Is it set, too?
##########
pom.xml:
##########
@@ -330,13 +333,15 @@
<exclude>**/spring.factories</exclude>
<exclude>**/spring.provides</exclude>
<exclude>**/*.iml</exclude>
+ <exclude>**/nb-configuration.xml</exclude>
+ <exclude>**/faces-config.NavData</exclude>
Review Comment:
This could also be in the `.gitignore` file.
##########
pom.xml:
##########
@@ -1462,6 +1474,8 @@
<exclude>**/spring.factories</exclude>
<exclude>**/spring.provides</exclude>
<exclude>**/*.iml</exclude>
+ <exclude>**/nb-configuration.xml</exclude>
+ <exclude>**/faces-config.NavData</exclude>
Review Comment:
Same as above
##########
pom.xml:
##########
@@ -1575,6 +1589,16 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
+ <surefire.argLine>-Xshare:off ${failsafe.argLine}</surefire.argLine>
Review Comment:
-1, `-Xshare:off` will not work on all JDKs (like non-hotspot-JDKs as OpenJ9 which comes with IBM Semeru). Either additionally check for a hotspot JDK or just leave it out. It should not be required anyway.
##########
pom.xml:
##########
@@ -577,6 +588,9 @@
<excludes>
<exclude>**/main/**/samples/**</exclude>
</excludes>
+ <address>localhost</address>
+ <port>${jacocoPort}</port>
+ <propertyName>jacocoAgent</propertyName>
Review Comment:
Why is this needed? Why was it not needed before?
##########
pom.xml:
##########
@@ -1575,6 +1589,16 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
Review Comment:
As far as I can see, this should not be needed anymore. Even then, we already have this in the guice projects so it should not live here for ALL modules. Only those which need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] (wip) Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1056757942
##########
pom.xml:
##########
@@ -543,6 +548,12 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
+ <configuration>
+ <compilerArgs>
+ <arg>-Xlint:deprecation</arg>
+ <arg>-Xlint:unchecked</arg>
+ </compilerArgs>
+ </configuration>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1055759518
##########
pom.xml:
##########
@@ -1575,6 +1589,16 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
+ <surefire.argLine>-Xshare:off ${failsafe.argLine}</surefire.argLine>
Review Comment:
OpenJ9 (Semuru) works perfectly with `-Xshare:off`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1055603856
##########
pom.xml:
##########
@@ -1575,6 +1589,16 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
Review Comment:
Liberty tests use .net opens. Are those not needs anymore? I can remove those if not needed. The base opens late needed for arquillian and selenium tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] (wip) Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1056757931
##########
pom.xml:
##########
@@ -330,13 +333,15 @@
<exclude>**/spring.factories</exclude>
<exclude>**/spring.provides</exclude>
<exclude>**/*.iml</exclude>
+ <exclude>**/nb-configuration.xml</exclude>
+ <exclude>**/faces-config.NavData</exclude>
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
fpapon commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1057594888
##########
pom.xml:
##########
@@ -71,12 +71,14 @@
<buildNumber>${user.name}-${maven.build.timestamp}</buildNumber>
<project.build.outputTimestamp>2022-03-22T23:08:15Z</project.build.outputTimestamp>
<jacoco.skip>true</jacoco.skip>
+ <surefire.version>3.0.0-M7</surefire.version>
<!--suppress CheckTagEmptyBody -->
<surefire.argLine></surefire.argLine>
<!--suppress CheckTagEmptyBody -->
<failsafe.argLine></failsafe.argLine>
<nexus.deploy.skip>false</nexus.deploy.skip>
-
+ <jacocoPort>52212</jacocoPort>
Review Comment:
Is it possible to use a random port? We can have some conflicts on CI platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1063996989
##########
pom.xml:
##########
@@ -1575,6 +1599,15 @@
</pluginManagement>
</build>
</profile>
+ <profile>
+ <id>jdk11plus</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activation>
+ <properties>
+ <surefire.argLine>-XX:+IgnoreUnrecognizedVMOptions -Xshare:off</surefire.argLine>
+ </properties>
+ </profile>
Review Comment:
Small comment about why this exists would be appreciated.
##########
pom.xml:
##########
@@ -1462,6 +1485,7 @@
<exclude>**/spring.factories</exclude>
<exclude>**/spring.provides</exclude>
<exclude>**/*.iml</exclude>
+ <exclude>**/target/**</exclude>
Review Comment:
Only informational: This should already be included due to `.gitignore` (but doesn't hurt here either).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org