You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2006/07/22 18:44:45 UTC
Re: svn commit: r20826 - trunk/build/generator
djh@tigris.org wrote:
> Author: djh
> Date: Sat Jul 22 11:04:15 2006
> New Revision: 20826
>
> Modified:
> trunk/build/generator/gen_win.py
>
> Log:
> Fix swig perl bindings build on Windows.
>
> * build/generator/gen_win.py
> (get_win_includes): Add subversion directory to include dirs
> so swig projects can see the svn_private_config.h file.
>
>
>
> Modified: trunk/build/generator/gen_win.py
> URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/gen_win.py?pathrev=20826&r1=20825&r2=20826
> ==============================================================================
> --- trunk/build/generator/gen_win.py (original)
> +++ trunk/build/generator/gen_win.py Sat Jul 22 11:04:15 2006
> @@ -634,6 +634,7 @@
> self.path("subversion/bindings/swig/proxy"),
> self.path("subversion/bindings/swig/include"),
> self.path("subversion/include"),
> + self.path("subversion"),
> self.path(util_includes),
> self.apath(self.apr_path, "include"),
> self.apath(self.apr_util_path, "include") ]
>
Bravo. +1 from me to merge this to the 1.4 branch, it was a showstopper.
I just don't understand why the common include paths (subversion/include
and subversion) aren't always set ... they should be.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r20826 - trunk/build/generator
Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/22/06, Branko Čibej <br...@xbc.nu> wrote:
> djh@tigris.org wrote:
> > Author: djh
> > Date: Sat Jul 22 11:04:15 2006
> > New Revision: 20826
> >
> > Modified:
> > trunk/build/generator/gen_win.py
> >
> > Log:
> > Fix swig perl bindings build on Windows.
> >
> > * build/generator/gen_win.py
> > (get_win_includes): Add subversion directory to include dirs
> > so swig projects can see the svn_private_config.h file.
> >
> >
> >
> > Modified: trunk/build/generator/gen_win.py
> > URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/gen_win.py?pathrev=20826&r1=20825&r2=20826
> > ==============================================================================
> > --- trunk/build/generator/gen_win.py (original)
> > +++ trunk/build/generator/gen_win.py Sat Jul 22 11:04:15 2006
> > @@ -634,6 +634,7 @@
> > self.path("subversion/bindings/swig/proxy"),
> > self.path("subversion/bindings/swig/include"),
> > self.path("subversion/include"),
> > + self.path("subversion"),
> > self.path(util_includes),
> > self.apath(self.apr_path, "include"),
> > self.apath(self.apr_util_path, "include") ]
> >
>
> Bravo. +1 from me to merge this to the 1.4 branch, it was a showstopper.
>
> I just don't understand why the common include paths (subversion/include
> and subversion) aren't always set ... they should be.
>
> -- Brane
>
Yes, next time I'm in there I'll refactor that a bit. I'm doing a
build and test with this and a few other changes to the Windows build
generator, so this will be part of that backport set if it all works
well.
DJ