[jira] Commented: (MECLIPSE-213) more jee support for wtp

["Brian Fox (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104871 ] 

Brian Fox commented on MECLIPSE-213:
------------------------------------

Hi Rich, I sent you this email several weeks ago but perhaps it was  blocked:

Hi Ritchie,
I tried applying your patch. Unfortunately, svn doesn't handle newly added files in patches very well, especially binary ones. Can you do the following?

Remove all files from the tree that are not new, leaving behind just the tree of new files, and zip it up? Then attach it or email it to me. I'll take this zip and unpack it over the eclipse folder and apply the rest of your patch. I can then submit it to a branch where we can review it and tweak if needed before merging.

Thanks,
Brian


> more jee support for wtp
> ------------------------
>
>                 Key: MECLIPSE-213
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-213
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: WTP support
>    Affects Versions: 2.3
>         Environment: linux suse 10.0 eclipse 3.2.1 and wtp 1.5.1 java 1.5.0_8
>            Reporter: Richard van Nieuwenhoven
>         Attachments: maven-eclipse-plugin-2.3-CFC-2007-03-08.patch, maven-eclipse-plugin-2.3-PATCH-2007-03-08.tgz, maven-eclipse-plugin-R494407.patch, maven-eclipse-plugin.patch
>
>
> I tried the new release 2.3 of the eclipse plugin and noteted that not alle of my paches where included. 
> I re-pached the 2.3 version again this time i made my changes configurable so they can be turned on and off.
> my changes:
> - prohibit dupicate entries in the classpath
>     provided system paths in combination with log4j/commons-logging/xerces can easely create such problems
> - system paths are only included in ears and war when they are inside the project
>    bether behavior would be to exclude all system paths because the war and ear plugin also ignore these
> - an application.xml specialy for eclipse-wtp 
>    this makes wtp ears function correctly it includes the eclipse project modules instead of the maven generated jars
> - manifest generation for wtp
>    wtp needs manifest files, but not the ones maven creates because they have version names for all modules etc
>    this generates a wtp manifest that will be in a ons eclipse source directory that is ignored my maven itself
> use the parameters  -Declipse.wtpmanifest=true -Declipse.wtpapplicationxml=true  to acivate the patch.
> The manifest generator could be combined with the RadManifestWriter in the future, they are almost the same.
> regards,
> Ritchie

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira