[GitHub] [airflow] mik-laj edited a comment on issue #6954: [AIRFLOW-4355] removed task should not lead to dagrun success

[GitBox <gi...@apache.org>]

mik-laj edited a comment on issue #6954: [AIRFLOW-4355] removed task should not lead to dagrun success
URL: https://github.com/apache/airflow/pull/6954#issuecomment-571398463
 
 
   It works for me.
   ```python
       @conf_vars({
           ('scheduler', 'removed_tasks_lead_to_dagrun_failure'): 'True'
       })
       def test_dagrun_removed_tasks_lead_to_dagrun_failure_true(self):
           session = settings.Session()
           on_failure_callback = mock.MagicMock()
           dag = DAG(
               'test_dagrun_removed_tasks_lead_to_dagrun_failure_true',
               start_date=DEFAULT_DATE,
               default_args={'owner': 'owner1'},
               on_failure_callback=on_failure_callback
           )
           dag.clear()
           with dag:
               op1 = DummyOperator(task_id='A')
               op2 = DummyOperator(task_id='B')
               op2.set_upstream(op1)
   
           dag.clear()
           now = timezone.utcnow()
           dr = dag.create_dagrun(run_id='test_dagrun_deadlock',
                                  state=State.RUNNING,
                                  execution_date=now,
                                  start_date=now)
   
           ti_op1 = dr.get_task_instance(task_id=op1.task_id)
           ti_op1.set_state(state=State.REMOVED, session=session)
           ti_op2 = dr.get_task_instance(task_id=op2.task_id)
           ti_op2.set_state(state=State.SUCCESS, session=session)
           del dag.task_dict[ti_op1.task_id]
   
           dr.update_state()
           self.assertEqual(dr.state, State.FAILED)
           kall = on_failure_callback
           callback_context = kall.call_args[0][0]
           self.assertEqual('removed_tasks', callback_context['reason'])
   
       @conf_vars({
           ('scheduler', 'removed_tasks_lead_to_dagrun_failure'): 'False'
       })
       def test_dagrun_removed_tasks_lead_to_dagrun_failure_false(self):
           session = settings.Session()
           on_failure_callback = mock.MagicMock()
           dag = DAG(
               'test_dagrun_removed_tasks_lead_to_dagrun_failure_false',
               start_date=DEFAULT_DATE,
               default_args={'owner': 'owner1'},
               on_success_callback=on_failure_callback
           )
           dag.clear()
           with dag:
               op1 = DummyOperator(task_id='A')
               op2 = DummyOperator(task_id='B')
               op2.set_upstream(op1)
   
           dag.clear()
           now = timezone.utcnow()
           dr = dag.create_dagrun(run_id='test_dagrun_deadlock',
                                  state=State.RUNNING,
                                  execution_date=now,
                                  start_date=now)
   
           ti_op1 = dr.get_task_instance(task_id=op1.task_id)
           ti_op1.set_state(state=State.REMOVED, session=session)
           ti_op2 = dr.get_task_instance(task_id=op2.task_id)
           ti_op2.set_state(state=State.SUCCESS, session=session)
           del dag.task_dict[ti_op1.task_id]
   
           dr.update_state()
           self.assertEqual(dr.state, State.SUCCESS)
           kall = on_failure_callback
           callback_context = kall.call_args[0][0]
           self.assertEqual('success', callback_context['reason'])
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services