You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:35:28 UTC
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2198: sim: support LCD emulation over X11; correctly decouple LCD/FB from X11/NX
v01d commented on a change in pull request #2198:
URL: https://github.com/apache/incubator-nuttx/pull/2198#discussion_r516088614
##########
File path: arch/sim/Kconfig
##########
@@ -257,28 +245,54 @@ config SIM_FBBPP
If you use the X11 display emulation, the selected BPP must match the BPP
of your graphics hardware (probably 32 bits). Default: 8
-endif # SIM_FRAMEBUFFER
+endmenu
+
+choice
+ prompt "Graphics Device"
+ default SIM_LCDDRIVER
+ ---help---
+ Choose which kind of graphics device to emulate
+
+config SIM_LCDDRIVER
+ bool "LCD device"
+ default y
Review comment:
done
##########
File path: arch/sim/Kconfig
##########
@@ -257,28 +245,54 @@ config SIM_FBBPP
If you use the X11 display emulation, the selected BPP must match the BPP
of your graphics hardware (probably 32 bits). Default: 8
-endif # SIM_FRAMEBUFFER
+endmenu
+
+choice
+ prompt "Graphics Device"
+ default SIM_LCDDRIVER
+ ---help---
+ Choose which kind of graphics device to emulate
+
+config SIM_LCDDRIVER
+ bool "LCD device"
+ default y
+ depends on LCD
+ ---help---
+ Emulate an LCD driver
+
+config SIM_FRAMEBUFFER
+ bool "Framebuffer"
+ default n
Review comment:
done
##########
File path: arch/sim/src/Makefile
##########
@@ -125,10 +125,14 @@ ifeq ($(CONFIG_RTC_DRIVER),y)
CSRCS += up_rtc.c
endif
-ifeq ($(CONFIG_NX_LCDDRIVER),y)
+ifeq ($(CONFIG_SIM_LCDDRIVER),y)
CSRCS += up_lcd.c
else
- CSRCS += up_framebuffer.c
+ ifeq ($(CONFIG_SIM_FRAMEBUFFER),y)
Review comment:
if you don't have other observations can be leave it like this for now? I'm juggling various branches and I have to go back and rebase changes each time. I already have ready the putarea() PR waiting for this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org