You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2015/06/01 08:31:20 UTC
incubator-zeppelin git commit: Fix abnormal height of chart in IE
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master ad3c28bb6 -> b74bdb66f
Fix abnormal height of chart in IE
I fixed https://issues.apache.org/jira/browse/ZEPPELIN-91 issue.
This issue is related to abnormal height of chart in IE. Please refer to the link below for more details.
https://github.com/NFLabs/zeppelin/issues/417
Author: Hyungu Roh <hy...@navercorp.com>
Closes #85 from 1teed/fix_graph_height and squashes the following commits:
29cc711 [Hyungu Roh] Fix abnormal height of chart in IE
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/b74bdb66
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/b74bdb66
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/b74bdb66
Branch: refs/heads/master
Commit: b74bdb66f0b56b5718f185782e19ca6152f2576c
Parents: ad3c28b
Author: Hyungu Roh <hy...@navercorp.com>
Authored: Thu May 28 11:23:12 2015 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon Jun 1 15:30:54 2015 +0900
----------------------------------------------------------------------
zeppelin-web/app/scripts/controllers/paragraph.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/b74bdb66/zeppelin-web/app/scripts/controllers/paragraph.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/app/scripts/controllers/paragraph.js b/zeppelin-web/app/scripts/controllers/paragraph.js
index f9b77e8..bb8e19d 100644
--- a/zeppelin-web/app/scripts/controllers/paragraph.js
+++ b/zeppelin-web/app/scripts/controllers/paragraph.js
@@ -912,11 +912,11 @@ angular.module('zeppelinWebApp')
var chartEl = d3.select('#p'+$scope.paragraph.id+'_'+type+' svg')
.attr('height', $scope.paragraph.config.graph.height)
+ .style('height', height + 'px')
.datum(d3g)
.transition()
.duration(animationDuration)
.call($scope.chart[type]);
- d3.select('#p'+$scope.paragraph.id+'_'+type+' svg').style.height = height+'px';
nv.utils.windowResize($scope.chart[type].update);
};