You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/07 00:38:31 UTC
[GitHub] [spark] nchammas opened a new pull request #27840: [SPARK-31075]
Add documentation for ALTER TABLE ... ADD PARTITION
nchammas opened a new pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840
### What changes were proposed in this pull request?
This PR adds documentation for `ALTER TABLE ... ADD PARTITION`.
### Why are the changes needed?
Every bit of major Spark SQL syntax should be documented so users know that it's there and how to use it.
### Does this PR introduce any user-facing change?
Yes, documentation only.
### How was this patch tested?
Built and reviewed the docs locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596022393
cc @huaxingao, who I believe created the main `ALTER TABLE` docs, and @srowen, who has reviewed SQL doc additions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596021665
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596023367
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119494/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596027099
Ah, I missed that. Thanks for the pointer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596023361
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas closed pull request #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas closed pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596023367
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119494/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596023308
**[Test build #119494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119494/testReport)** for PR 27840 at commit [`09f8441`](https://github.com/apache/spark/commit/09f844100f9a2cc9ffad27ba496fd16a79c9a816).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#discussion_r389206587
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +83,37 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ADD PARTITION
+
+`ALTER TABLE ADD PARTITION` adds a new partition to an existing, partitioned table.
+
+#### Syntax
+
+```sql
Review comment:
I don't know why we are using Jinja directives when basic Markdown suffices, but if we really want to stick to the more verbose `{% highlight sql %}` I am happy to switch to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#discussion_r389207041
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +83,37 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ADD PARTITION
+
+`ALTER TABLE ADD PARTITION` adds a new partition to an existing, partitioned table.
+
+#### Syntax
+
+```sql
+ALTER TABLE <table_identifier> ADD [IF NOT EXISTS]
+ PARTITION <partition_spec> [LOCATION 'location']
+ [ PARTITION <partition_spec> [LOCATION 'location'] ...]
+;
+
+<table_identifier> ::=
+ [ database_name. ]table_name
+
+<partition_spec> ::=
+ (partition_column = partition_col_value, partition_column = partition_col_value, ...)
+```
+
+#### Examples
Review comment:
Instead of having all examples at the end, I think it's clearer and easier to follow when each command has examples in its own section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596021669
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24223/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596021665
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27840: [SPARK-31075]
Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596021476
**[Test build #119494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119494/testReport)** for PR 27840 at commit [`09f8441`](https://github.com/apache/spark/commit/09f844100f9a2cc9ffad27ba496fd16a79c9a816).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#discussion_r389206587
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +83,37 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ADD PARTITION
+
+`ALTER TABLE ADD PARTITION` adds a new partition to an existing, partitioned table.
+
+#### Syntax
+
+```sql
Review comment:
I don't know why we are using Jinja directives when basic Markdown suffices (since no language selector is needed here), but if we really want to stick to the more verbose `{% highlight sql %}` I am happy to switch to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#discussion_r389206936
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +83,37 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ADD PARTITION
+
+`ALTER TABLE ADD PARTITION` adds a new partition to an existing, partitioned table.
+
+#### Syntax
+
+```sql
+ALTER TABLE <table_identifier> ADD [IF NOT EXISTS]
+ PARTITION <partition_spec> [LOCATION 'location']
+ [ PARTITION <partition_spec> [LOCATION 'location'] ...]
+;
+
+<table_identifier> ::=
+ [ database_name. ]table_name
+
+<partition_spec> ::=
Review comment:
I know we currently have parameters described in a separate section, but I believe having the syntax all described at once is clearer. This also follows the style of [Microsoft's SQL Server docs](https://docs.microsoft.com/en-us/sql/t-sql/statements/create-table-transact-sql), which I believe are a great model to follow.
But if we really want to stick to the separate "Parameters" section with HTML-based lists, I can switch to that. But I will likely propose in a separate PR that we eliminate raw HTML from these SQL docs unless they are absolutely necessary.
For parameters that need explanation, I suppose we'd still need a separate "Parameters" section, but it would focus on explaining how they work rather than showing syntax. And in this case here I don't think that's necessary since the syntax and examples are good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596023361
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596024915
@nchammas Thank you very much for working on this. @kevinyu98 has submitted PR https://github.com/apache/spark/pull/27779 to add the missing ALTER TABLE statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596021669
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24223/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27840:
[SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#discussion_r389206936
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +83,37 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ADD PARTITION
+
+`ALTER TABLE ADD PARTITION` adds a new partition to an existing, partitioned table.
+
+#### Syntax
+
+```sql
+ALTER TABLE <table_identifier> ADD [IF NOT EXISTS]
+ PARTITION <partition_spec> [LOCATION 'location']
+ [ PARTITION <partition_spec> [LOCATION 'location'] ...]
+;
+
+<table_identifier> ::=
+ [ database_name. ]table_name
+
+<partition_spec> ::=
Review comment:
I know we currently have parameters described in a separate section, but I believe having the syntax all described at once is clearer. This also follows the style of [Microsoft's SQL Server docs](https://docs.microsoft.com/en-us/sql/t-sql/statements/create-table-transact-sql), which I believe are a great model to follow.
But if we really want to stick to the separate "Parameters" section with HTML-based lists, I can switch to that. But I will likely propose in a separate PR that we eliminate raw HTML from these SQL docs unless they are absolutely necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27840: [SPARK-31075] Add
documentation for ALTER TABLE ... ADD PARTITION
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27840: [SPARK-31075] Add documentation for ALTER TABLE ... ADD PARTITION
URL: https://github.com/apache/spark/pull/27840#issuecomment-596021476
**[Test build #119494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119494/testReport)** for PR 27840 at commit [`09f8441`](https://github.com/apache/spark/commit/09f844100f9a2cc9ffad27ba496fd16a79c9a816).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org