You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/19 19:11:33 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #3895: Simplify `a AND a` and `a OR a`.

alamb opened a new issue, #3895:
URL: https://github.com/apache/arrow-datafusion/issues/3895

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   Some features like https://github.com/apache/arrow-datafusion/pull/3859 may find / introduce seemingly nonsensical predicates like `a AND a` -- in this case the expression simplifier should remove them. 
   
   **Describe the solution you'd like**
   Add rewrite rules to rewrite
   `a AND a` --> `a`
   `a OR a` --> `a`
   
   Rewrite rules are https://github.com/apache/arrow-datafusion/blob/feff5dc/datafusion/optimizer/src/simplify_expressions.rs#L793
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on issue #3895: Simplify `a AND a` and `a OR a`.

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3895:
URL: https://github.com/apache/arrow-datafusion/issues/3895#issuecomment-1287758139

   As pointed out by @src255 this is already implemented https://github.com/apache/arrow-datafusion/pull/3915#issuecomment-1287373139 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on issue #3895: Simplify `a AND a` and `a OR a`.

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3895:
URL: https://github.com/apache/arrow-datafusion/issues/3895#issuecomment-1284478505

   Marking as good first issue as there are many examples and existing tests to follow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb closed issue #3895: Simplify `a AND a` and `a OR a`.

Posted by GitBox <gi...@apache.org>.
alamb closed issue #3895: Simplify `a AND a` and `a OR a`.
URL: https://github.com/apache/arrow-datafusion/issues/3895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] retikulum commented on issue #3895: Simplify `a AND a` and `a OR a`.

Posted by GitBox <gi...@apache.org>.
retikulum commented on issue #3895:
URL: https://github.com/apache/arrow-datafusion/issues/3895#issuecomment-1285633105

   I will take a look!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org