You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/19 00:38:34 UTC
Re: Review Request 61706: Added Autotools rules to build the CSI
client module in Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61706/
-----------------------------------------------------------
(Updated Aug. 19, 2017, 12:38 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
Changes
-------
Updated due to changes upper in the review chain.
Bugs: mesos-7491
https://issues.apache.org/jira/browse/mesos-7491
Repository: mesos
Description
-------
Added Autotools rules to build the CSI client module in Mesos.
Diffs (updated)
-----
3rdparty/Makefile.am 21828379197858ae2b92648c1d18d3eb1bc7fb7c
3rdparty/versions.am 82d66be7d25ba9b8753f3c6b60415d991074b1a9
src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55
Diff: https://reviews.apache.org/r/61706/diff/2/
Changes: https://reviews.apache.org/r/61706/diff/1-2/
Testing
-------
../configure --enable-grpc
make distcheck DISTCHECK_CONFIGURE_FLAGS="--enable-grpc"
Thanks,
Chun-Hung Hsiao
Re: Review Request 61706: Added Autotools rules to build the CSI
client module in Mesos.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61706/#review183287
-----------------------------------------------------------
Bad patch!
Reviews applied: [61706, 61705, 61704, 61703, 61748, 61600]
Failed command: python support/apply-reviews.py -n -r 61703
Error:
error: missing binary patch data for '3rdparty/csi-0.1.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.1.0.tar.gz'
error: 3rdparty/csi-0.1.0.tar.gz: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/257/console
- Mesos Reviewbot Windows
On Aug. 19, 2017, 12:38 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61706/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Autotools rules to build the CSI client module in Mesos.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 21828379197858ae2b92648c1d18d3eb1bc7fb7c
> 3rdparty/versions.am 82d66be7d25ba9b8753f3c6b60415d991074b1a9
> src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55
>
>
> Diff: https://reviews.apache.org/r/61706/diff/2/
>
>
> Testing
> -------
>
> ../configure --enable-grpc
> make distcheck DISTCHECK_CONFIGURE_FLAGS="--enable-grpc"
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61706: Added Autotools rules to build the CSI
client module in Mesos.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61706/#review183529
-----------------------------------------------------------
Fix it, then Ship it!
src/Makefile.am
Lines 448-450 (patched)
<https://reviews.apache.org/r/61706/#comment259536>
Do we need this yet?
- Jie Yu
On Aug. 19, 2017, 12:38 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61706/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Autotools rules to build the CSI client module in Mesos.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 21828379197858ae2b92648c1d18d3eb1bc7fb7c
> 3rdparty/versions.am 82d66be7d25ba9b8753f3c6b60415d991074b1a9
> src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55
>
>
> Diff: https://reviews.apache.org/r/61706/diff/2/
>
>
> Testing
> -------
>
> ../configure --enable-grpc
> make distcheck DISTCHECK_CONFIGURE_FLAGS="--enable-grpc"
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>