[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #319: Integrate sbt-license-report

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#discussion_r1193614578


##########
project/Dependencies.scala:
##########
@@ -75,44 +75,44 @@ object Dependencies {
   object Compile {
     // Compile
 
-    val config = "com.typesafe" % "config" % "1.4.2" // ApacheV2
-    val netty = "io.netty" % "netty" % nettyVersion // ApacheV2
+    val config = "com.typesafe" % "config" % "1.4.2"

Review Comment:
   It sounds to me a better solution to this problem would be to add functionality into `sbt-license-report` to throw an error if ucategorized licenses are found (uncategorized is the fallback for when no license is detected). This can work in conjunction with `licenseFilter`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org