You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Dan Dumont (JIRA)" <ji...@apache.org> on 2012/06/05 14:49:23 UTC
[jira] [Reopened] (SHINDIG-1762) Add code to handle OpenSocial
Embedded Experience Container Context extension per
http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
[ https://issues.apache.org/jira/browse/SHINDIG-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont reopened SHINDIG-1762:
---------------------------------
Henry, sorry for the late review, but it looks like the code you added to the open-views ee feature doesn't account for async element creation.
The review site is down now, but it looks like in the code if the element is created async, the augmented context will never get passed to the callback.
I don't see why it ever needs to be passed to the callback, why can't you init the context before you define the callback and use the outer scope reference instead of passing it in?
> Add code to handle OpenSocial Embedded Experience Container Context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1762
> URL: https://issues.apache.org/jira/browse/SHINDIG-1762
> Project: Shindig
> Issue Type: New Feature
> Components: Java, Javascript
> Affects Versions: 2.5.0-beta1, 2.5.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Fix For: 2.5.0-beta2
>
>
> Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec:
> http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
> http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira