You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/09 22:44:28 UTC

[GitHub] OlegZhukov commented on a change in pull request #7436: [FLINK-11071][core] add support for dynamic proxy classes resolution …

OlegZhukov commented on a change in pull request #7436: [FLINK-11071][core] add support for dynamic proxy classes resolution …
URL: https://github.com/apache/flink/pull/7436#discussion_r246565932
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java
 ##########
 @@ -91,6 +92,40 @@ public ClassLoaderObjectInputStream(InputStream in, ClassLoader classLoader) thr
 			return super.resolveClass(desc);
 		}
 
+		@Override
+		protected Class<?> resolveProxyClass(String[] interfaces) throws IOException, ClassNotFoundException {
 
 Review comment:
   I'm wondering if a test case can be written for this. Is there a test case for correctly resolving classes in a basic (non-proxy case)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services