You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/12 02:28:34 UTC

[GitHub] [spark] Ngone51 opened a new pull request #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Ngone51 opened a new pull request #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   In the error message, adding an example for typed Scala UDF.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Help user to know how to migrate to typed Scala UDF.
   
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   No, it's a new error message in Spark 3.0.
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Pass Jenkins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598037695
 
 
   **[Test build #119690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119690/testReport)** for PR 27884 at commit [`9da8b59`](https://github.com/apache/spark/commit/9da8b59b0d3e06ee23c6b911b761e169f3f71d95).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598154169
 
 
   Merged to master and branch-3.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597975090
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598037786
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598037791
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119690/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598154066
 
 
   I am going to just merge. build and linters passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597976620
 
 
   **[Test build #119690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119690/testReport)** for PR 27884 at commit [`9da8b59`](https://github.com/apache/spark/commit/9da8b59b0d3e06ee23c6b911b761e169f3f71d95).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597975096
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24419/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598153810
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597975090
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598037791
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119690/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598500359
 
 
   thanks all!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597975096
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24419/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597977689
 
 
   cc @gatorsmile @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-597976620
 
 
   **[Test build #119690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119690/testReport)** for PR 27884 at commit [`9da8b59`](https://github.com/apache/spark/commit/9da8b59b0d3e06ee23c6b911b761e169f3f71d95).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27884: [SPARK-31010][SQL][FOLLOW-UP] Give an example for typed Scala UDF in error message
URL: https://github.com/apache/spark/pull/27884#issuecomment-598037786
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org