You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/18 13:00:37 UTC

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

twalthr commented on a change in pull request #7932:  [FLINK-11727][formats] Fixed JSON format issues after serialization 
URL: https://github.com/apache/flink/pull/7932#discussion_r266421832
 
 

 ##########
 File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowFormatFactory.java
 ##########
 @@ -58,20 +58,26 @@ public JsonRowFormatFactory() {
 		final DescriptorProperties descriptorProperties = getValidatedProperties(properties);
 
 		// create and configure
-		final JsonRowDeserializationSchema schema = new JsonRowDeserializationSchema(createTypeInformation(descriptorProperties));
+		final JsonRowDeserializationSchema.Builder schema =
+			new JsonRowDeserializationSchema.Builder(createTypeInformation(descriptorProperties))
+				;
 
 Review comment:
   nit: to line above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services