You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/01/09 11:26:03 UTC

[jira] [Commented] (HIVE-3140) Comment indenting is broken for "describe" in CLI

    [ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547950#comment-13547950 ] 

Hudson commented on HIVE-3140:
------------------------------

Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
    HIVE-3140 Comment indenting is broken for "describe" in CLI
(Zhenxiao Luo via namit) (Revision 1418405)

     Result = ABORTED
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418405
Files : 
* /hive/trunk/contrib/src/test/results/clientpositive/fileformat_base64.q.out
* /hive/trunk/contrib/src/test/results/clientpositive/serde_s3.q.out
* /hive/trunk/hbase-handler/src/test/results/positive/hbase_queries.q.out
* /hive/trunk/hwi/src/test/org/apache/hadoop/hive/hwi/TestHWISessionManager.java
* /hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
* /hive/trunk/ql/src/test/queries/clientpositive/describe_comment_indent.q
* /hive/trunk/ql/src/test/results/clientnegative/desc_failure2.q.out
* /hive/trunk/ql/src/test/results/clientnegative/drop_partition_filter_failure2.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_part_no_drop.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl2.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl3.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl4.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl5.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl_no_drop.q.out
* /hive/trunk/ql/src/test/results/clientnegative/set_hiveconf_validation0.q.out
* /hive/trunk/ql/src/test/results/clientnegative/set_hiveconf_validation1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter3.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter4.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter5.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter_index.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter_merge_2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter_merge_stats.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter_partition_format_loc.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter_table_serde.q.out
* /hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
* /hive/trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out
* /hive/trunk/ql/src/test/results/clientpositive/authorization_7.q.out
* /hive/trunk/ql/src/test/results/clientpositive/autogen_colalias.q.out
* /hive/trunk/ql/src/test/results/clientpositive/avro_change_schema.q.out
* /hive/trunk/ql/src/test/results/clientpositive/avro_evolved_schemas.q.out
* /hive/trunk/ql/src/test/results/clientpositive/avro_joins.q.out
* /hive/trunk/ql/src/test/results/clientpositive/avro_sanity_test.q.out
* /hive/trunk/ql/src/test/results/clientpositive/avro_schema_error_message.q.out
* /hive/trunk/ql/src/test/results/clientpositive/avro_schema_literal.q.out
* /hive/trunk/ql/src/test/results/clientpositive/ba_table1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/ba_table2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/ba_table_union.q.out
* /hive/trunk/ql/src/test/results/clientpositive/binary_table_bincolserde.q.out
* /hive/trunk/ql/src/test/results/clientpositive/binary_table_colserde.q.out
* /hive/trunk/ql/src/test/results/clientpositive/bucket_groupby.q.out
* /hive/trunk/ql/src/test/results/clientpositive/columnarserde_create_shortcut.q.out
* /hive/trunk/ql/src/test/results/clientpositive/combine3.q.out
* /hive/trunk/ql/src/test/results/clientpositive/convert_enum_to_string.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_default_prop.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_escape.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_insert_outputformat.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_nested_type.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_view.q.out
* /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
* /hive/trunk/ql/src/test/results/clientpositive/database.q.out
* /hive/trunk/ql/src/test/results/clientpositive/ddltime.q.out
* /hive/trunk/ql/src/test/results/clientpositive/describe_comment_indent.q.out
* /hive/trunk/ql/src/test/results/clientpositive/describe_syntax.q.out
* /hive/trunk/ql/src/test/results/clientpositive/describe_table.q.out
* /hive/trunk/ql/src/test/results/clientpositive/describe_xpath.q.out
* /hive/trunk/ql/src/test/results/clientpositive/drop_partitions_filter.q.out
* /hive/trunk/ql/src/test/results/clientpositive/drop_partitions_filter2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/drop_partitions_filter3.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_00_nonpart_empty.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_01_nonpart.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_02_00_part_empty.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_02_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_03_nonpart_over_compat.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_all_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_05_some_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_06_one_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_07_all_part_over_nonoverlap.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_08_nonpart_rename.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_09_part_spec_nonoverlap.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_10_external_managed.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_11_managed_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_12_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_13_managed_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_14_managed_location_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_15_external_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_18_part_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_19_00_part_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_19_part_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_20_part_managed_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/fileformat_sequencefile.q.out
* /hive/trunk/ql/src/test/results/clientpositive/fileformat_text.q.out
* /hive/trunk/ql/src/test/results/clientpositive/index_creation.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inoutdriver.q.out
* /hive/trunk/ql/src/test/results/clientpositive/input1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/input10.q.out
* /hive/trunk/ql/src/test/results/clientpositive/input15.q.out
* /hive/trunk/ql/src/test/results/clientpositive/input2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/input3.q.out
* /hive/trunk/ql/src/test/results/clientpositive/input_part10.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl3.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl4.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl5.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl6.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl7.q.out
* /hive/trunk/ql/src/test/results/clientpositive/inputddl8.q.out
* /hive/trunk/ql/src/test/results/clientpositive/join_thrift.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part10.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part11.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part12.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part13.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part14.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part3.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part4.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part5.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part6.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part7.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part8.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_dyn_part9.q.out
* /hive/trunk/ql/src/test/results/clientpositive/load_fs.q.out
* /hive/trunk/ql/src/test/results/clientpositive/multi_sahooks.q.out
* /hive/trunk/ql/src/test/results/clientpositive/partition_schema1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/protectmode.q.out
* /hive/trunk/ql/src/test/results/clientpositive/protectmode2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/rcfile_bigdata.q.out
* /hive/trunk/ql/src/test/results/clientpositive/rcfile_columnar.q.out
* /hive/trunk/ql/src/test/results/clientpositive/rcfile_default_format.q.out
* /hive/trunk/ql/src/test/results/clientpositive/rename_column.q.out
* /hive/trunk/ql/src/test/results/clientpositive/serde_reported_schema.q.out
* /hive/trunk/ql/src/test/results/clientpositive/show_columns.q.out
* /hive/trunk/ql/src/test/results/clientpositive/split_sample.q.out
* /hive/trunk/ql/src/test/results/clientpositive/stats0.q.out
* /hive/trunk/ql/src/test/results/clientpositive/tablename_with_select.q.out
* /hive/trunk/ql/src/test/results/clientpositive/updateAccessTime.q.out

                
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
>                 Key: HIVE-3140
>                 URL: https://issues.apache.org/jira/browse/HIVE-3140
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Xiaoxiao Hou
>            Assignee: Zhenxiao Luo
>              Labels: patch
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3140.1.patch.txt, HIVE-3140.2.patch.txt, hive.3140.3.patch, HIVE-3140.3.patch.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam         string             1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam         string             1 = comment1
>                                          2 = comment2
>                                          3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira